Add support for filtering and pagination on job output #9208
Conversation
|
Build succeeded.
|
|
Build succeeded.
|
| let pageSize; | ||
|
|
||
| if (startIndex === stopIndex) { | ||
| page = startIndex; |
There was a problem hiding this comment.
I think there's an off-by-one here.
| page = startIndex; | |
| page = startIndex + 1; |
A reproducer for the bug is when startIndex = 50 and stopIndex = 50:
|
@mabashian It would be good to make a note of it in the changelog |
| if (hasContentLoading) { | ||
| return <ContentLoading />; | ||
| } |
There was a problem hiding this comment.
To reduce "flashing" during search, we could move <ContentLoading/> further down into the Job Output.
<AutoSizer nonce={window.NONCE_ID} onResize={handleResize}>
{({ width, height }) => {
return (
<>
{hasContentLoading ? (
<div style={{ width }}>
<ContentLoading />
</div>
) : (
<List
ref={ref => {
registerChild(ref);
listRef.current = ref;
}}
...
mabashian
force-pushed
the
job-output-search-2
branch
from
63a56da to
d66bc83
Compare
|
Build succeeded.
|
|
Build failed.
|
|
Build failed.
|
|
@jakemcdermott @marshmalien OK, I think I've got this one rebased and ready to go with y'alls suggested changes. |
|
Build succeeded.
|
|
@mabashian lgtm 👍 note: There's another merge conflict from a recent pr |
|
Note: this is our highest priority this week. @mabashian can you rebase? |
mabashian
force-pushed
the
job-output-search-2
branch
from
dfca799 to
3595d35
Compare
|
Build succeeded.
|
|
Hey, folks- found this issue while I was poking around: If you provide the wrong type of input for a filter you will have to navigate out and back to the job details page to start over
|
|
@unlikelyzero do you think that this feature could be ready and included in newest AWX release? |
|
@mabashian "while you're in there" can you update the locators identified in #9495 |
mabashian
force-pushed
the
job-output-search-2
branch
from
ce6ab93 to
73fb332
Compare
|
Build succeeded.
|
|
In reference to #9495, I've added a commit to add ouiaId's to the following things: Relaunch (Dropdown version which allows users to select all or just failed hosts):
Relaunch (Regular button version):
Download:
Delete:
Cancel:
|
|
Build succeeded.
|
Findings
|
…tton was shown instead of delete
|
Build succeeded.
|
|
@mabashian any chance you could add data-ouia-ids on the page controls? |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
SUMMARY
link #6612
link #5906
This PR adds the ability to filter job events and also includes logic to handle fetching filtered job events across different pages.
Note that the
verbositydropdown included in #5906 is not included in this work. I don't think that's possible without api changes.As part of this work, I converted JobOutput.jsx from a class based component to a functional component. I've tried my best to make sure that all existing functionality has remained the same by comparing the experience of this branch to devel.
Like the old UI, the output filter is disabled while the job is running.
ISSUE TYPE
COMPONENT NAME