Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory File field and playbook field are both now type ahead. #9120

Merged

Conversation

AlexSCorey
Copy link
Member

SUMMARY

This addresses:

  1. inventory file field should be typable #9043
  2. Makes Playbook drop down on the JT Form a type ahead component
  3. prevents 'Custom Details` from rendering when Source field in the Inventory Source form is blank or when Custom is selected.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • UI
AWX VERSION
ADDITIONAL INFORMATION

Screen Shot 2021-01-20 at 3 24 16 PM
Screen Shot 2021-01-20 at 3 21 26 PM
Screen Shot 2021-01-20 at 3 21 03 PM

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@unlikelyzero
Copy link

@AlexSCorey will this need to be rebased to include the changes made to the credential typeahead component?

@AlexSCorey AlexSCorey force-pushed the 9043-InventoryFileField branch from 540fe9e to 1898049 Compare February 22, 2021 14:18
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@ryanpetrello
Copy link
Contributor

Hey.

@AlexSCorey

Hey.

This is awesome.

@tiagodread
Copy link
Contributor

@AlexSCorey some feedback after use this feature:

  1. allow users to send manual type in
  2. allow users to scroll when the list is too large
  3. close the list after clicking
  4. add IDs to the list items

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Copy link
Contributor

@tiagodread tiagodread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the user can:

  • type and select a playbook
  • type and select an inventory file
  • type in and create an entry for a existing file even if not visible in the list

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@barkely128
Copy link

Umm, has this been merged in the new 17.1.0 release? I just updated my AWX all happy that I'll finally be able to use my yaml hosts files for different environments from a single git folder, only to find out I still can't type the names manually.

@christiangfeller
Copy link

It's not fixed. I am still not able to edit manaully the inventory file field.
Installed AWX 17.1.0 on OpenShift.

@barkely128
Copy link

It's not fixed. I am still not able to edit manaully the inventory file field.
Installed AWX 17.1.0 on OpenShift.

As a workaround you can use f12 in Chrome and Firefox to manually edit the field's name and most importantly - value.
Not pretty, but it works and I managed to setup my 2 inventories, which lie in a single git folder. If you've checked the boxes to update it after project sync, then you should be able to live without doing this too often.

@christiangfeller
Copy link

It's not fixed. I am still not able to edit manaully the inventory file field.
Installed AWX 17.1.0 on OpenShift.

As a workaround you can use f12 in Chrome and Firefox to manually edit the field's name and most importantly - value.
Not pretty, but it works and I managed to setup my 2 inventories, which lie in a single git folder. If you've checked the boxes to update it after project sync, then you should be able to live without doing this too often.

Thank you @barkely128
it works with this f12 workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui type:bug type:feature prioritized on a feature board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants