Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ws or wss proto #8877

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Support ws or wss proto #8877

merged 1 commit into from
Dec 15, 2020

Conversation

jakemcdermott
Copy link
Contributor

@jakemcdermott jakemcdermott commented Dec 11, 2020 •
edited
Loading

SUMMARY

Use ws when on http and wss when on https

related: #8881

@jakemcdermott jakemcdermott force-pushed the ws-proto branch 3 times, most recently from f38c95a to 39fe4f0 Compare December 11, 2020 23:34
@jakemcdermott jakemcdermott force-pushed the ws-proto branch 2 times, most recently from 2e317e7 to 97cfbcc Compare December 12, 2020 00:08
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@unlikelyzero
Copy link

Note: no additional coverage is needed. Once e2e is 🟢 this will be implicitly tested

@jakemcdermott jakemcdermott mentioned this pull request Dec 14, 2020
Closed
AlexSCorey
AlexSCorey approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@jakemcdermott
Copy link
Contributor Author

jakemcdermott commented Dec 15, 2020 •
edited
Loading

re:

Note: no additional coverage is needed. Once e2e is green_circle this will be implicitly tested

1 e2e failure: https://dashboard.cypress.io/projects/ui2mq7/runs/3606/overview

...but it's the workflow visualizer notifications tab test which I've observed to be flakey and failing occasionally on other branches: e.g: https://dashboard.cypress.io/projects/ui2mq7/runs/3607/overview

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3ae6ea9 into ansible:devel Dec 15, 2020
@jakemcdermott
Copy link
Contributor Author

related: #8932

@jakemcdermott jakemcdermott mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSCorey AlexSCorey AlexSCorey approved these changes

@keithjgrant keithjgrant keithjgrant approved these changes

@mabashian mabashian Awaiting requested review from mabashian

@jlmitch5 jlmitch5 Awaiting requested review from jlmitch5

@chrismeyersfsu chrismeyersfsu Awaiting requested review from chrismeyersfsu

@marshmalien marshmalien Awaiting requested review from marshmalien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakemcdermott @unlikelyzero @keithjgrant @AlexSCorey