Zedr wfjt inventories #8353
Merged
Zedr wfjt inventories #8353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7798 This changeset introduces two changes: 1. Update the API representation of Workflow Job Templates to use the natural key of the Inventory type instead of its id; 2. Override the related property of the CLI's WorkflowJobTemplate page type to patch the related references during the export process, allowing the resource to be serialised using the natural key of the Inventory type instead of the id. Change n.2 is a workaround that is used when exporting resources from AWX/Tower instances that don't have change n.1. It can be removed in the future.
|
Build succeeded.
|
AlanCoding
reviewed
Oct 9, 2020
|
Build succeeded.
|
rebeccahhh
approved these changes
Oct 9, 2020
|
@zedr you interested in giving this PR a whirl? |
|
Good for me! |
|
works for me, confirmed that the |
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The current version of AWX fails to include the url to a non-null Inventory foreign key in the API results for a Workflow Job Template. This PR finishes off work from @zedr to both add that link the the API output, but also attempt a reasonable fallback when using the awx-cli export function against a version of AWX that does not have this fix.
related #7798
ISSUE TYPE
COMPONENT NAME
AWX VERSION