Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a display bug in notification bodies with unicode characters #8313

Merged
merged 1 commit into from
Oct 2, 2020
Merged

fix a display bug in notification bodies with unicode characters #8313

merged 1 commit into from
Oct 2, 2020

Conversation

ryanpetrello
Copy link
Contributor

@ryanpetrello ryanpetrello commented Oct 2, 2020 •
edited
Loading

see: #7400

https://docs.python.org/3/library/json.html#json.dump

If ensure_ascii is true (the default), the output is guaranteed to have all incoming non-ASCII characters escaped. If ensure_ascii is false, these characters will be output as-is.

@ryanpetrello ryanpetrello mentioned this pull request Oct 2, 2020
Closed
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@ryanpetrello ryanpetrello force-pushed the fix-garbled-unicode-in-notifications branch from 46c6723 to 30b6fd2 Compare October 2, 2020 18:37
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0b824ee into ansible:devel Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeankha beeankha beeankha approved these changes

@rebeccahhh rebeccahhh Awaiting requested review from rebeccahhh

@jladdjr jladdjr Awaiting requested review from jladdjr

@elyezer elyezer Awaiting requested review from elyezer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanpetrello @beeankha