clean up old authtoken support #7937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanpetrello
requested review from
AlanCoding,
beeankha,
elyezer,
kdelee and
squidboylan
just use Bearer tokens - those are the only type of tokens we support
ryanpetrello
force-pushed
the
only-bearer
branch
from
6453fe4 to
815d691
Compare
beeankha
approved these changes
Aug 19, 2020
ryanpetrello
commented
Aug 19, 2020
| @@ -57,7 +56,7 @@ def login(self, username=None, password=None, token=None, **kwargs): | |||
| else: | |||
| self.session.auth = (username, password) | |||
| elif token: | |||
| self.session.auth = Token_Auth(token, auth_type=kwargs.get('auth_type', 'Token')) | |||
There was a problem hiding this comment.
This default is wrong, and doesn't even work anymore.
|
Build succeeded.
|
john-westcott-iv
approved these changes
Aug 19, 2020
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just use Bearer tokens - those are the only type of tokens we support