Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'inputs' Unchanged When Blank in Credentials Module #7840

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion awx_collection/plugins/modules/tower_credential.py
Original file line number Diff line number Diff line change
Expand Up @@ -384,19 +384,25 @@ def main():
team_id = module.resolve_name_to_id('teams', team)

# Create credential input from legacy inputs
has_inputs = False
credential_inputs = {}
for legacy_input in OLD_INPUT_NAMES:
if module.params.get(legacy_input) is not None:
has_inputs = True
credential_inputs[legacy_input] = module.params.get(legacy_input)

if inputs:
has_inputs = True
credential_inputs.update(inputs)

# Create the data that gets sent for create and update
credential_fields = {
'name': new_name if new_name else name,
'credential_type': cred_type_id,
'inputs': credential_inputs,
}
if has_inputs:
credential_fields['inputs'] = credential_inputs

if description:
credential_fields['description'] = description
if organization:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,19 @@
that:
- result is changed

- name: Check for inputs idempotency (when "inputs" is blank)
tower_credential:
name: "{{ ssh_cred_name2 }}"
organization: Default
state: present
credential_type: Machine
description: An example SSH credential
register: result

- assert:
that:
- result is not changed

- name: Create a valid SSH credential from lookup source (old school)
tower_credential:
name: "{{ ssh_cred_name3 }}"
Expand Down