Handle form submission errors that may be deeply nested in the return object #7821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
jakemcdermott
approved these changes
Aug 4, 2020
jakemcdermott
approved these changes
Aug 4, 2020
| @@ -2,6 +2,26 @@ import React, { useState, useEffect } from 'react'; | |||
| import { useFormikContext } from 'formik'; | |||
| import { Alert } from '@patternfly/react-core'; | |||
|
|
|||
| const findErrorStrings = (obj, messages = []) => { | |||
| if (typeof obj === 'string') { | |||
| messages.push(obj); | |||
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
link #7814
The issue here was that the error message for an error on the
urlfield in the credential form was nested down in the second level of the return object. The code that we previously had in FormSubmitError didn't handle that very well so I built a recursive solution that will traverse the entire object and gather up all of the strings in an array to be displayed in the Alert. This solution also handles arrays of strings which can happen when a field has multiple errors.ISSUE TYPE
COMPONENT NAME