Adds support for toggling approval notifications on orgs and wfjts #7803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
jakemcdermott
approved these changes
Aug 10, 2020
dsesami
suggested changes
Aug 20, 2020
There was a problem hiding this comment.
This has an issue that @jakemcdermott experienced with a similar list of toggles. Basically, if you toggle one item, it disables ALL the toggles and flashes them (even if there are 10 different, unrelated notifications on the page). This can be jarring visually to the user. Jake's approach was to make sure that only the row involving that particular notification was disabled during the animation.
mabashian
force-pushed
the
6425-approval-notif
branch
from
5f919ae to
681b765
Compare
dsesami
approved these changes
Aug 20, 2020
|
Build succeeded.
|
|
@mabashian will merge this after tests pass. |
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
resolves #6425
Here it is in action:
I needed to add the methods to the org/wfjt api models directly because not every model that consumes that mixin will have an
approvalsendpoint.ISSUE TYPE
COMPONENT NAME