-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM image build support #7607
ARM image build support #7607
Conversation
Build failed.
|
7496d8f
to
fe92e0f
Compare
Build failed.
|
fe92e0f
to
0b841e6
Compare
Build failed.
|
Build failed.
|
0b841e6
to
9e3cc0b
Compare
Build failed.
|
Build succeeded.
|
Ping @jakemcdermott. JFYI, this bumps the version of chromedriver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will let this sit for another day or so for more feedback to trickle in, but I'm +1 on this.
I think my biggest concern about this is not the work in this PR, but in how we add CI so we avoid breaking it long term (every time we add some dependency, we'll have to make sure we don't break ARM support?) |
dnf -y install centos-release-stream && dnf -y install "rsyslog >= 8.1911.0" && dnf -y remove centos-release-stream && \ | ||
dnf -y clean all | ||
|
||
# Install kubectl | ||
RUN curl -L -o /usr/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/v1.17.8/bin/linux/{{ kubectl_architecture | default('amd64') }}/kubectl && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to do this in a way that doesnt require pinning the version of kubectl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The k8s docs[1] show using a command like the following, but I personally don't like that for various reasons.
curl -LO "https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl"
@ryanpetrello I think saying this is only "community supported" is fine... we have plenty of other install paths that aren't tested by either upstream or downstream tests. |
chromedriver bump should be fine as long as unit tests still work and are passing. That appears to be the case so LGTM. |
Build failed (gate pipeline). For information on how to proceed, see
|
Why do the SSL connections randomly get closed when running these tests? There seems to be some trouble with the test infra, because I really doubt that |
regate |
Build failed (gate pipeline). For information on how to proceed, see
|
* upgrade `chromedriver` for ARM support * upgrade `pynacl` to fix `libsodium` build issue on ARM * remove unnecessary i686-specific `libstdc++.so.6` package * install `kubectl` and `tini` from upstream binaries for ARM support * use upstream `postgres` and `alpine` docker images for `postgresql` helm chart Fixes ansible#7051
9e3cc0b
to
02252f3
Compare
Build succeeded.
|
Yea, I'm not totally sure what's going on here. It seems specific to this URL, though: https://storage.googleapis.com/kubernetes-release/release/v1.17.8/bin/linux/amd64/kubectl @shanemcd, you have any ideas? |
Build failed (gate pipeline). For information on how to proceed, see
|
regate |
Build failed (gate pipeline). For information on how to proceed, see
|
regate |
Build succeeded (gate pipeline).
|
I've just run into the standard_init_linux.go:228: exec user process caused: exec format error and realised there was architecture incompatibility. In the first instance it'd be really good to get some pointers about getting this running on aarch64 but adding CI for aarch64 would be great too! |
SUMMARY
This commit adds support for building AWX docker images on ARM/64
chromedriver
for ARM supportpynacl
to fixlibsodium
build issue on ARMlibstdc++.so.6
packagekubectl
andtini
from upstream binaries for ARM supportpostgres
andalpine
docker images forpostgresql
helm chartFixes #7051
ISSUE TYPE
COMPONENT NAME
AWX VERSION
N/A
ADDITIONAL INFORMATION
N/A