Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix searching for a blank string creates a blank search filter #6786

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

nixocio
Copy link
Contributor

@nixocio nixocio commented Apr 21, 2020

Fix searching for a blank string creates a blank search filter. Also,
add unit-test to the related changes.

closes: #6511

@nixocio nixocio requested a review from jlmitch5 April 21, 2020 20:35
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Copy link
Contributor

@jlmitch5 jlmitch5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

wrapper.find(searchButton).simulate('click');

expect(onSearch).toHaveBeenCalledTimes(0);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great tests!

@dsesami dsesami self-requested a review April 22, 2020 20:14
Fix searching for a blank string creates a blank search filter. Also,
add unit-test to the related changes.

closes: ansible#6511
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b6be891 into ansible:devel Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching for a blank string creates a blank search filter
4 participants