remove python2 support from awxkit #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanpetrello
requested review from
elyezer,
kdelee,
Spredzy,
squidboylan,
beeankha and
jbradberry
ryanpetrello
commented
Mar 18, 2020
| @@ -67,7 +67,7 @@ def run(self): | |||
| }, | |||
| include_package_data=True, | |||
| install_requires=requirements, | |||
| python_requires=">=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*", | |||
| python_requires=">=3.6", | |||
There was a problem hiding this comment.
Should we start adding Trove classifiers to the setup.py? Are we intending to make awxkit, or at least awx-cli, available on pypi.org?
There was a problem hiding this comment.
We don't currently publish to PyPI (and don't have plans to in the near future), but if we did in the future then we should definitely add Trove classifiers 👍
|
Build failed.
|
jbradberry
reviewed
Mar 18, 2020
ryanpetrello
force-pushed
the
py2-minus-minus-cli
branch
from
359a1e7 to
08a1741
Compare
|
Build failed.
|
ryanpetrello
force-pushed
the
py2-minus-minus-cli
branch
from
08a1741 to
f900dd4
Compare
There was a problem hiding this comment.
https://github.com/ansible/awx/blob/devel/awxkit/awxkit/api/pages/credentials.py#L22
It'll continue to work fine, but this block can go if you feel like removing it.
|
Build succeeded.
|
ryanpetrello
force-pushed
the
py2-minus-minus-cli
branch
from
f900dd4 to
0b62898
Compare
ryanpetrello
force-pushed
the
py2-minus-minus-cli
branch
from
0b62898 to
06b3e54
Compare
| try: | ||
| json.loads(data) | ||
| except err: | ||
| except json.decoder.JSONDecodeError: |
chrismeyersfsu
approved these changes
Mar 19, 2020
rooftopcellist
approved these changes
Mar 19, 2020
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
AlexSCorey
pushed a commit
to AlexSCorey/awx
that referenced
this pull request
Jul 26, 2023
…ra-vars [4.3] Fixes bug where attempting to edit a schedule with stringified extra_data threw error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.