only restrict OAuth2 tokens for external accounts *at creation time* #5499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanpetrello
commented
Dec 13, 2019
| @@ -146,5 +141,6 @@ def validate_external_users(self): | |||
| ).format(external_account)) | |||
|
|
|||
| def save(self, *args, **kwargs): | |||
| self.validate_external_users() | |||
There was a problem hiding this comment.
Only prevent OAuth2 tokens for external accounts at creation time. Changing this means people can:
settings.ALLOW_OAUTH2_FOR_EXTERNAL_USERS = True- Create an OAuth2 token for a certain LDAP-backed user.
settings.ALLOW_OAUTH2_FOR_EXTERNAL_USERS = False- At this point, LDAP users can no longer make new OAuth2 tokens
- The token from step 2 will continue to function (until it's revoked).
There was a problem hiding this comment.
This lines up with how we explain its use in the docs and honestly makes tokens more useful for auditing in larger orgs.
|
Build failed.
|
ryanpetrello
force-pushed
the
more-oauth-tinkering
branch
from
50b84ba to
a7a3609
Compare
|
Build succeeded.
|
matburt
approved these changes
Dec 16, 2019
|
Build succeeded (gate pipeline).
|
AlanCoding
pushed a commit
to AlanCoding/awx
that referenced
this pull request
Feb 4, 2022
[4.1 Backport] Avoid duplicated entries when calling create_preload_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #5477
cc @gamuniz