General dependency upgrades (awx venv only for now) #5407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
force-pushed
the
depgrades_2019_party
branch
from
0d4ae3e to
7d7584c
Compare
|
Looks like the swagger failure was introduced by an upgrade of DRF in this between the two versions encode/django-rest-framework@3.9.4...3.10.0 and I know that it was introduced before 7762aaa90f92ff30e521931db2ec65c52f8da98e, still searching locally. |
|
passes with encode/django-rest-framework@9811a29 fails with encode/django-rest-framework@c3a1391 I think I'm confusing myself because they did branch merges, and I'm only interested in the 3.10 branch |
|
introduced in encode/django-rest-framework@37f210a
encode/django-rest-framework#6532
|
AlanCoding
force-pushed
the
depgrades_2019_party
branch
2 times, most recently
from
998598b to
ecd9c29
Compare
|
Don't want to lose this |
AlanCoding
force-pushed
the
depgrades_2019_party
branch
from
ecd9c29 to
011be46
Compare
AlanCoding
force-pushed
the
depgrades_2019_party
branch
2 times, most recently
from
12f30a7 to
d30da5b
Compare
AlanCoding
force-pushed
the
depgrades_2019_party
branch
from
fc9e780 to
d62770b
Compare
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
AlanCoding
force-pushed
the
depgrades_2019_party
branch
2 times, most recently
from
39ddb50 to
11e198a
Compare
|
Build succeeded.
|
shanemcd
approved these changes
Dec 20, 2019
Versions selected to be pre-19 pip due to unresolved issues with the build systems Upgrade everything, party on document new process rotate license files fix Swagger schema generation target Remove --ignore-installed flag
this is in addition to pip and setuptools installs add in --ignore-installed and --no-build-isolation flags reasoning is that we are not installing needed packages for building
Remove build isolation flag Do not use --ignore-installed for any pip install commands Add Makefile comments do not use system site packages for awx venv Consolidate bootstrap pins Do another upgrade, properly document wheel
Remove poetry and wheel from bootstrap installs Cleanup some docs around them
AlanCoding
force-pushed
the
depgrades_2019_party
branch
from
11e198a to
18bb910
Compare
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
AlanCoding
pushed a commit
to AlanCoding/awx
that referenced
this pull request
Nov 9, 2021
Display host name for Associate Modal See: ansible#11256
shanemcd
pushed a commit
to shanemcd/awx
that referenced
this pull request
Nov 10, 2021
Display host name for Associate Modal See: ansible#11256
shanemcd
pushed a commit
to shanemcd/awx
that referenced
this pull request
Nov 10, 2021
Display host name for Associate Modal See: ansible#11256
shanemcd
pushed a commit
to shanemcd/awx
that referenced
this pull request
Nov 10, 2021
Display host name for Associate Modal See: ansible#11256
AlexSCorey
pushed a commit
to AlexSCorey/awx
that referenced
this pull request
Dec 1, 2021
Display host name for Associate Modal See: ansible#11256
TinLe
pushed a commit
to TinLe/awx
that referenced
this pull request
Jan 21, 2022
Display host name for Associate Modal See: ansible#11256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This implements a process change and does a general upgrade of everything in the AWX virtual environment which won't break things.
Like all dependency upgrades, most of the real work involves categorizing which things will break things on upgrade. To do this in a more maintainable way, I've written blurbs on those things we can't upgrade, and then unpinned the content in
requirements.infor those that don't break things.ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
This needs some corresponding changes to unblock upgrade of pip & setuptools, but I have been testing it with temporary hacks for that and everything is going fine, so it looks like the ecosystem has worked out enough to not error here.