-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to a pre-19 pip version #5363
Conversation
Build succeeded.
|
Unfortunately it is still giving the
error. |
I think we need to follow some form of instructions from: whatever is doing any variation Testing locally, |
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
Versions selected to be pre-19 pip due to unresolved issues with the build systems
This reverts commit daa092a.
Build succeeded.
|
with current approaches this is no longer necessary |
SUMMARY
Connect #3968
There is a lot of history here.
Previously, an upgrade to the latest pip was attempted, that was reverted as of #4114 and #4136, but the labeling there is confusing. Those weren't clean reverts, but eventually we settled back to the very old versions.
I have confirmed an error due to the latest pip & setuptools version which looks like:
This is related to pypa/pip#6164 and pypa/setuptools#1644 which I do not want to go within a mile of.
Pip version 19.0.0 was called out specifically in those issues. As such, dipping down to latest 18.x seems reasonable. Versions selected by inspecting history:
So I'm going to upgrade, pretending that today is Jan 21, 2019.
This is still almost exactly what the partial rollback did in #4114. However, there are several notable differences from there to here:
Makefile
are set to the same (conservative) versionssetuptools
has a slightly lower version, and there is reason to think it might play betterpip
version in one of the requirements file was still >19Importantly, I have not been able to replicate any of the fallout with this PR. It fixed issues I saw with the higher versions, so it would be reasonable to speculate that the issue was caused by the versions in the Makefile.
The hope is that this gets us past the old error:
But I still have yet to double and triple check that, and we should hold off merge until that time.
ISSUE TYPE
COMPONENT NAME
AWX VERSION