fix a bug that prevents launch-time passphrases w/ cred plugins #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2019
ryanpetrello
commented
Sep 23, 2019
| @@ -151,7 +151,7 @@ def needs_ssh_password(self): | |||
| @property | |||
| def has_encrypted_ssh_key_data(self): | |||
| try: | |||
| ssh_key_data = decrypt_field(self, 'ssh_key_data') | |||
| ssh_key_data = self.get_input('ssh_key_data') | |||
There was a problem hiding this comment.
I hate that we have to actually pull the value from the third party credential here (because it's in the HTTP request), but I can't think of any other way to do this correctly.
jladdjr
approved these changes
Sep 23, 2019
|
Build succeeded.
|
|
I tried editing the AWX container contents to apply this patch manually, then restarted web/task containers. It still doesn't seem to actually USE the passphrase, or at least the error screen still shows a prompt for the passphrase for the key data. |
|
Odd. I was able to apply a passphrase before/after this PR and run an adhoc command on my personal server using a passphrase I specified at launch time:
|
|
My bad, I had edited the web container venv, rather than the task venv. Once I edited the task one it seemed to work. |
ryanpetrello
force-pushed
the
cred-plugins-with-promptable-passphrase
branch
from
a79fc3e to
505acb5
Compare
|
Build failed.
|
|
recheck |
|
Build failed.
|
ryanpetrello
force-pushed
the
cred-plugins-with-promptable-passphrase
branch
from
505acb5 to
4844005
Compare
|
Build failed.
|
with the advent of credential plugins there's no way for us to *actually
know* the RSA key value at the time the credential is _created_, because
the order of operations is:
1. Create the credential with a specified passphrase
2. Associate a new dynamic inventory source pointed at some third party
provider (hashi, cyberark, etc...)
this commit removes the code that warns you about an extraneous
passphrase (if you don't specify a private key)
additionally, the code for determining whether or not a credential
_requires_ a password/phrase at launch time has been updated to test
private key validity based on the *actual* value from the third party
provider
see: ansible#4791
ryanpetrello
force-pushed
the
cred-plugins-with-promptable-passphrase
branch
from
4844005 to
d30d51d
Compare
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the advent of credential plugins there's no way for us to actually
know the RSA key value at the time the credential is created, because
the order of operations is:
provider (hashi, cyberark, etc...)
this commit removes the code that warns you about an extraneous
passphrase (if you don't specify a private key)
additionally, the code for determining whether or not a credential
requires a password/phrase at launch time has been updated to test
private key validity based on the actual value stored in the third party
provider
see: #4791