Send job & org data #4472
Merged
Send job & org data #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
|
Interesting considerations:
|
rooftopcellist
force-pushed
the
collection_org_job_info
branch
from
79c3824 to
2e58bc5
Compare
|
Build failed.
|
rooftopcellist
force-pushed
the
collection_org_job_info
branch
from
2e58bc5 to
282b736
Compare
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
awx/main/analytics/collectors.py
Outdated
| AND main_project.unifiedjobtemplate_ptr_id = main_job.project_id | ||
| AND main_unifiedjob.polymorphic_ctype_id = django_content_type.id | ||
| AND main_unifiedjob.launch_type != 'sync' | ||
| AND main_organization.id = main_project.organization_id |
There was a problem hiding this comment.
@AlanCoding @rooftopcellist we're going to have to reconsider this after your merge of the "org on JT" feature.
There was a problem hiding this comment.
@ryanpetrello I have discussed this with @AlanCoding and we decided to merge this first and then make any necessary changes when Alan's PR lands.
|
Build failed (gate pipeline). For information on how to proceed, see
|
elyezer
requested changes
Aug 19, 2019
There was a problem hiding this comment.
I will change my review to request changes since I observed that we are having duplicated rows on the generated report, for example:
id,polymorphic_ctype_id,model,organization_id,organization_name,created,name,unified_job_template_id,launch_type,schedule_id,execution_node,controller_node,cancel_flag,status,failed,started,finished,elapsed,job_explanation,instance_group_id
9,40,projectupdate,1,Default,2019-08-19 19:29:10.901595+00,Demo Project,6,dependency,,localhost,"",f,successful,f,2019-08-19 19:29:16.849771+00,2019-08-19 19:29:20.24345+00,3.394,"",1
9,40,projectupdate,1,Default,2019-08-19 19:29:10.901595+00,Demo Project,6,dependency,,localhost,"",f,successful,f,2019-08-19 19:29:16.849771+00,2019-08-19 19:29:20.24345+00,3.394,"",1
9,40,projectupdate,1,Default,2019-08-19 19:29:10.901595+00,Demo Project,6,dependency,,localhost,"",f,successful,f,2019-08-19 19:29:16.849771+00,2019-08-19 19:29:20.24345+00,3.394,"",1
Already talked to @rooftopcellist and he will take a look.
|
Build failed.
|
rooftopcellist
force-pushed
the
collection_org_job_info
branch
2 times, most recently
from
365c3bf to
27e5602
Compare
|
Build succeeded.
|
|
This is now producing better results but I still getting duplicated entries: That job template:
Is associated with a single project:
And it is only associated with the |
rooftopcellist
force-pushed
the
collection_org_job_info
branch
from
27e5602 to
cd3645e
Compare
|
Build succeeded.
|
elyezer
approved these changes
Aug 26, 2019
|
regate |
|
Build succeeded (gate pipeline).
|
softwarefactory-project-zuul bot
added a commit
that referenced
this pull request
Aug 26, 2019
Send job & org data Reviewed-by: Christian Adams <[email protected]> https://github.com/rooftopcellist
ryanpetrello
pushed a commit
to ryanpetrello/awx
that referenced
this pull request
Aug 5, 2020
Upgrade community.vmware for better error surfacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Related: #4473
Expands the query to copy the unified_jobs table for analytics collection to include the organization name.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Stay tuned of performance notes.