Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open source awxkit #4451

Merged
merged 2 commits into from
Aug 9, 2019
Merged

open source awxkit #4451

merged 2 commits into from
Aug 9, 2019

Conversation

ryanpetrello
Copy link
Contributor

No description provided.

@ryanpetrello @simfarm
@jakemcdermott @kdelee @AlanCoding @Spredzy
import awxkit
9616cc6 
Co-authored-by: Christopher Wang <[email protected]>
Co-authored-by: Jake McDermott <[email protected]>
Co-authored-by: Jim Ladd <[email protected]>
Co-authored-by: Elijah DeLee <[email protected]>
Co-authored-by: Alan Rominger <[email protected]>
Co-authored-by: Yanis Guenane <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@unlikelyzero unlikelyzero removed their request for review August 9, 2019 12:55
@unlikelyzero
Copy link

I'm going to leave this to people more familiar with towerkit to review

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@ryanpetrello
include awxkit CI in zuul runs
adaa414 
additionally, fix up some flake8 failures
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

kdelee
kdelee approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@kdelee kdelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: expect more PRs from me to awx! 🚀

matburt
matburt approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@matburt matburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an absolutely monumental amount of work, and nicely laid out here in the AWX source tree.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 76a1099 into ansible:devel Aug 9, 2019
@piroux
Copy link
Contributor

piroux commented Aug 12, 2019

I am trying to understand the scope of this PR, which is quite big to digest for an outsider.

In the awxkit/README.md, I found :

Python library that backs the provided `awx` command line client.

From its pages sub-modules, I understand that it redefines all AWX objects in order to interact though the HTTP API
https://github.com/ansible/awx/pull/4451/files#diff-06ee91b3a50623f1464c8ca42b2fdf4b
https://github.com/ansible/awx/pull/4451/files#diff-f7ddb7c4c5525818c5373136c4940693R269

I feel that there is a lot of overlapping with the tower-cli project, so does it mean that awxkit is going to replace it ?

@matburt
Copy link
Member

matburt commented Aug 12, 2019

This is indeed intended to be the replacement for tower-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelee kdelee kdelee approved these changes

@matburt matburt matburt approved these changes

@jladdjr jladdjr Awaiting requested review from jladdjr

@Spredzy Spredzy Awaiting requested review from Spredzy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryanpetrello @unlikelyzero @piroux @matburt @kdelee