Show notification menu to users with notification_admin team role #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
jakemcdermott
approved these changes
Jul 30, 2019
| @@ -46,7 +46,7 @@ describe('Components | Layout', () => { | |||
| $httpBackend.when('GET', /admin_of_organizations/) | |||
| .respond(mockOrgAdminResponse); | |||
|
|
|||
| $httpBackend.when('GET', /roles\/\?role_field=notification_admin_role/) | |||
| $httpBackend.when('GET', /organizations\/\?role_level=notification_admin_role/) | |||
|
Build succeeded.
|
|
Build failed (gate pipeline). For information on how to proceed, see
|
|
regate |
|
Build succeeded (gate pipeline).
|
ryanpetrello
added a commit
to ryanpetrello/awx
that referenced
this pull request
Aug 5, 2020
Add queue / instance group registration to heartbeat for k8s installs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Notifications (in the side nav) was hidden from users who were granted the notification admin role through a team permission. This PR fixes that.
The previous endpoint only returns whether or not the user has been explicitly granted the notification admin role on the org.
ISSUE TYPE
COMPONENT NAME