Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a bug introduced in the inventory source detail API by v1 removal #4074

Merged
merged 1 commit into from
Jun 19, 2019
Merged

fix a bug introduced in the inventory source detail API by v1 removal #4074

merged 1 commit into from
Jun 19, 2019

Conversation

ryanpetrello
Copy link
Contributor

see: #4059

ryanpetrello
ryanpetrello commented Jun 13, 2019
View reviewed changes
awx/api/serializers.py
@@ -1943,6 +1943,26 @@ def validate(self, attrs):

return super(InventorySourceOptionsSerializer, self).validate(attrs)

# TODO: remove when old 'credential' fields are removed
Copy link
Contributor Author

@ryanpetrello ryanpetrello Jun 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little too liberal in /api/v1/ removal; this shouldn't have been removed.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1413c1b into ansible:devel Jun 19, 2019
@ryanpetrello ryanpetrello mentioned this pull request Jun 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismeyersfsu chrismeyersfsu chrismeyersfsu approved these changes

@AlanCoding AlanCoding Awaiting requested review from AlanCoding

@kdelee kdelee Awaiting requested review from kdelee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanpetrello @chrismeyersfsu @awxbot