Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attach private data dir to the bwrap environment #4073

Closed
wants to merge 1 commit into from

Conversation

matburt
Copy link
Member

@matburt matburt commented Jun 13, 2019

I'm thinking this may not be needed to have accessible by the bwrap environment running the playbook, and it's already available to the Runner process itself

This should wrap up #4010

I'm thinking this may not be needed to have accessible by the bwrap environment running the playbook, and it's already available to the Runner process itself
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@AlanCoding
Copy link
Member

Sometimes cwd is the private_data_dir, so those cases would see the same problem.

In #4001 (which will be in the final feature), we have to move the working directory from the project folder (which contains the playbook) to the project copy, which is in the private_data_dir.

Like I was doing there, I think you need to compare if the cwd either is the private data dir, or is a subdirectory of it, and if it is, you need to remove cwd as well.

@matburt
Copy link
Member Author

matburt commented Jun 14, 2019

In that case, AWX itself will have to be the one to remove the private_data_dir as that's one of the key things that runner assumes will hang around for a while. That case is also mostly true for the artifact directory

@matburt
Copy link
Member Author

matburt commented Jun 14, 2019

I need to think about this one more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants