Use public methods to reference registered models #15277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismeyersfsu
approved these changes
Jun 17, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In ansible/django-ansible-base#475 I found need to change the structure of
_registryin the permission registry... which fails the AWX downstream checks because it uses that. So I guess this is why we have public / private methods.This code was coppied over from DAB at some time, so that kind of explains how this reference seeped in. This is a really simple (easy) change, just change from referencing the internal variable to the public property that gives all the models.
The purpose is to unblock that DAB change.
ISSUE TYPE
COMPONENT NAME