Add check_instance_ready management command #15238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbradberry
suggested changes
May 30, 2024
|
|
||
| def handle(self, *args, **options): | ||
| if Instance.objects.me().node_state != Instance.States.READY: | ||
| raise Exception('Instance is not ready') # so that return code is not 0 |
There was a problem hiding this comment.
The correct way to exit out of Django commands with a failure is to raise CommandError (from django.core.management.base)
fosterseth
reviewed
May 30, 2024
fosterseth
reviewed
May 30, 2024
|
Thx for the review. Incorporated the suggestion plz rereview |
- throw exception and return 1 if instance not ready - return 0 if ready Update check_instance_ready.py Update check_instance_ready.py
TheRealHaoLiu
force-pushed
the
check-instance-ready
branch
from
b8a8b1b to
e6ca6dd
Compare
jbradberry
approved these changes
May 31, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
- throw exception and return 1 if instance not ready - return 0 if ready
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
- throw exception and return 1 if instance not ready - return 0 if ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
use by ansible/awx-operator#1885
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION