Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification name search #15231

Merged

Conversation

aeter
Copy link
Contributor

@aeter aeter commented May 27, 2024

SUMMARY

Fixes the partial search/filtering of Name under Administration->Notifications.
This PR makes it consistent with the rest of the website (Templates, Credentials, Projects) - where the partial Name filtering works.
This is, typing part of the name filters the right results.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • UI
AWX VERSION
ADDITIONAL INFORMATION

I couldn't find a github issue for it. Typing aaa finds/filters the right templates

notifications_fixed


Tested by:

  • added some filters (for Description, Name, etc.) manually and checking they continue to work
  • ran
npm run prettier
npm run lint
npm run test

@aeter aeter force-pushed the fix-notification-template-name-search branch from 54b6de3 to 57b017d Compare May 30, 2024 08:50
Signed-off-by: Adrian Nackov <[email protected]>
@aeter aeter force-pushed the fix-notification-template-name-search branch from 57b017d to 339c800 Compare June 5, 2024 09:28
@aeter
Copy link
Contributor Author

aeter commented Jun 5, 2024

Thanks for the review. I rebased (there was a failing CI check, also a message for an outdated devel branch). Hope it's ok now.

@fosterseth fosterseth enabled auto-merge (squash) June 5, 2024 19:24
@fosterseth fosterseth self-assigned this Jun 5, 2024
@fosterseth fosterseth merged commit d94f766 into ansible:devel Jun 13, 2024
21 checks passed
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants