Support Django logout redirects #15148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I probably don't even need to change |
thedoubl3j
changed the title
manstis
force-pushed
the
AAP-23125
branch
2 times, most recently
from
f48738e to
f587d2c
Compare
manstis
force-pushed
the
AAP-23125
branch
3 times, most recently
from
d91f847 to
01ae1a5
Compare
TheRealHaoLiu
approved these changes
May 13, 2024
Co-authored-by: Hao Liu <[email protected]>
rooftopcellist
approved these changes
May 13, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
* Allowed hosts for logout redirects can now be set via the LOGOUT_ALLOWED_HOSTS setting Authored-by: Michael Anstis <[email protected]> Co-authored-by: Hao Liu <[email protected]>
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
* Allowed hosts for logout redirects can now be set via the LOGOUT_ALLOWED_HOSTS setting Authored-by: Michael Anstis <[email protected]> Co-authored-by: Hao Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR allows specification of Django's
auth_views.LogoutView.success_url_allowed_hostsfromsettings.ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
This has been discussed on
#aap-controlleron Slack.I managed to step through the code with
sdbto check thesettingschange has no ill affect.This PR will need an accompanying PR for
awx-controllerto be able to set the new environment variable from then operator.This part of the code-base seems sparse of unit tests.. IDK if you require some?