Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LDAP/SAML config dump command #15106

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Update LDAP/SAML config dump command #15106

merged 4 commits into from
Apr 15, 2024

Conversation

jessicamack
Copy link
Member

SUMMARY

Fixes:

  • if a required field is missing return it so the user knows what to fix.
  • process LDAPSearch fields so command doesn't fail on them
  • keep field names consistent
  • use ansible_base package name
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other
AWX VERSION
awx: 24.1.1.dev13+gf0b0276e45
ADDITIONAL INFORMATION

@jessicamack jessicamack changed the title Update LDAP/SAML config dump cmmd Update LDAP/SAML config dump command Apr 12, 2024
@jessicamack jessicamack requested a review from fosterseth April 12, 2024 19:09
@jessicamack jessicamack requested a review from fosterseth April 12, 2024 21:54
@jessicamack jessicamack mentioned this pull request Apr 15, 2024
Open
@jessicamack jessicamack merged commit a176c04 into ansible:devel Apr 15, 2024
21 checks passed
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
@jessicamack @djyasin
Update LDAP/SAML config dump command (ansible#15106)
7e94f6b 
* update LDAP config dump

* return missing fields if any

* update test, remove unused import

* return bool and fields. check for missing_fields
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
@jessicamack @djyasin
Update LDAP/SAML config dump command (ansible#15106)
e9d2d41 
* update LDAP config dump

* return missing fields if any

* update test, remove unused import

* return bool and fields. check for missing_fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fosterseth fosterseth fosterseth approved these changes

@chrismeyersfsu chrismeyersfsu Awaiting requested review from chrismeyersfsu

@john-westcott-iv john-westcott-iv Awaiting requested review from john-westcott-iv

@TheRealHaoLiu TheRealHaoLiu Awaiting requested review from TheRealHaoLiu

Assignees
No one assigned
Labels
component:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicamack @fosterseth