-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #13119 #13120 Conjur Cloud support & update brand #13121
Fixes #13119 #13120 Conjur Cloud support & update brand #13121
Conversation
Hi! thanks for opening this PR, we are working with our QE team to see what further actions are needed before merging this in. In the meantime, can you provide more information about how you validated this change? Would this change break older usages of this credential? any compatibility concerns? |
I tested this using the AWX Docker dev environment against both self-hosted Conjur (current support) and Conjur Cloud (new support). It passed in both scenarios. Self-hosted Conjur supports the same API endpoints and paths as Conjur Cloud so there are no differences between the two. |
@infamousjoeg thanks so much for your contribution! Everything looks good, except that the old credential name is still showing up in the dropdown of the Credential add form- can you please fix this? |
I've removed the final reference to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
SUMMARY
Fixes #13119 & fixes #13120. Adds Conjur Cloud support and updates credential plugin name to
CyberArk Conjur Secrets Manager Lookup
.ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION