Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13119 #13120 Conjur Cloud support & update brand #13121

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

infamousjoeg
Copy link
Contributor

@infamousjoeg infamousjoeg commented Oct 26, 2022

SUMMARY

Fixes #13119 & fixes #13120. Adds Conjur Cloud support and updates credential plugin name to CyberArk Conjur Secrets Manager Lookup.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
  • UI
AWX VERSION
awx: 0.1.dev32506+g4a73356.d20221026
ADDITIONAL INFORMATION

image

@github-actions github-actions bot added component:awx_collection issues related to the collection for controlling AWX component:ui labels Oct 26, 2022
@fosterseth
Copy link
Member

Hi! thanks for opening this PR, we are working with our QE team to see what further actions are needed before merging this in.

In the meantime, can you provide more information about how you validated this change?

Would this change break older usages of this credential? any compatibility concerns?

@infamousjoeg
Copy link
Contributor Author

I tested this using the AWX Docker dev environment against both self-hosted Conjur (current support) and Conjur Cloud (new support). It passed in both scenarios.

Self-hosted Conjur supports the same API endpoints and paths as Conjur Cloud so there are no differences between the two.

@akus062381
Copy link
Member

@infamousjoeg thanks so much for your contribution!

Everything looks good, except that the old credential name is still showing up in the dropdown of the Credential add form- can you please fix this?

image

@infamousjoeg
Copy link
Contributor Author

@infamousjoeg thanks so much for your contribution!

Everything looks good, except that the old credential name is still showing up in the dropdown of the Credential add form- can you please fix this?

image

I've removed the final reference to CyberArk Conjur Secret Lookup that I could find in the entire code base. I did experience an issue with AWX previously when working on another external secret management system credential plugin that seemed like it cached the old name and I needed to redeploy AWX to get past. If the issue persists, that may be the remedy.

Copy link
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@TheRealHaoLiu TheRealHaoLiu merged commit e428384 into ansible:devel Nov 10, 2022
@infamousjoeg infamousjoeg deleted the conjur-cloud-and-branding branch November 11, 2022 01:47
@john-westcott-iv john-westcott-iv added the community pull request Applied to community based pull requests for filtering label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community pull request Applied to community based pull requests for filtering community component:api component:awx_collection issues related to the collection for controlling AWX component:ui
Projects
None yet
7 participants