Move model and settings operations out of threaded code #11837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
force-pushed
the
thread_key_error
branch
2 times, most recently
from
1dcd780 to
64873d3
Compare
This is to avoid references to settings in threads, this is known to create problems when caches expire this leads to KeyError in environments with heavy load
AlanCoding
force-pushed
the
thread_key_error
branch
from
64873d3 to
264c508
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We have some documentation on situations where we hit errors like those described here: tkem/cachetools#90
Most of our code is not thread-safe. We need to be careful to do as little as possible while we have this
ThreadPoolExecutoractive. Several of the kwargs can easily wind up referencingsettings, and this is a known hazard. Easiest thing to do is build all of these type of params before doing any threads, and I can't see any argument against it.ISSUE TYPE
COMPONENT NAME