-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Job Output expand/collapse #11193
[WIP] Job Output expand/collapse #11193
Conversation
83d95c6
to
3cb9c0b
Compare
dac8bcf
to
ac1ec94
Compare
We found so far:
|
This error occurred randomly while running the JT some times the job completes successfully, however, sometimes the page crash.
Screen.Recording.2021-10-07.at.10.49.39.mov
|
Concerns:
Nice to have:
|
Thanks @AlexSCorey! responses inline below:
This should work now
fixed
This is intentional. In order to only show lines that match the search query, I have to display all search results in "flat mode" (no hierarchy tree)... otherwise I would need to fetch parent/grandparent nodes, and they would get added to the display. This would mean it shows more logs beyond the search results.
No, each node remembers its expanded/collapsed state independently
Interesting ideas, and worth discussing with @trahman73, but I'm definitely going to punt on that for this PR :) |
@tiagodread This is ready for another once-over. I've smoothed over a lot of the rough edges (though I'm sure there's still more to find) |
07-2021-10-13_17.24.40.mp4
07-2021-10-13_17.29.47.mp4
07-2021-10-13_17.39.17.mp4 |
Closing in lieu of updated PR based on separate branch: #11312 11312 |
SUMMARY
Adds expand/collapse functionality to Job Output screen.
Addresses #6613
ISSUE TYPE
COMPONENT NAME