Adds support for workflow node aliasing via identifier field

[mabashian]

SUMMARY

link #2032

cc @AlanCoding since you may have opinions here based on your comments in the original issue.

The implementation leverages the identifier field on a workflow node in order to allow users to specify an alias to be displayed on the node instead of the resource name. This would allow users to uniquely identify nodes that have the same underlying unified job template. If the string is a uuid (generated by the server) then we still display the resource name.

Here it is in action:

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

• UI

[mabashian]

cc @wenottingham - if this is a bad idea let me know and we'll close this one

[softwarefactory-project-zuul]

Build succeeded.

• awx-api-lint : SUCCESS in 2m 33s
• awx-api : SUCCESS in 7m 25s
• awx-ui : SUCCESS in 15m 57s
• awx-swagger : SUCCESS in 6m 52s
• awx-detect-schema-change : SUCCESS in 8m 25s (non-voting)
• awx-ansible-modules : SUCCESS in 2m 40s

[wenottingham]

@mabashian no, this is neat. Is it plumbed through the job detail screen as well if you cllick into it on a workflow run?

[AlanCoding]

If the string is a uuid (generated by the server) then we still display the resource name.

That's pretty critical behavior. I think I agree with your decisions here.

Disclosure: I haven't actually looked at the code yet.

How are you distinguishing UUID type identifiers from user-given ones? Some pattern matching?

[mabashian]

How are you distinguishing UUID type identifiers from user-given ones? Some pattern matching?

yea right now it's just a regex match

[mabashian]

Is it plumbed through the job detail screen as well if you cllick into it on a workflow run?

I'll have to double check on this one

[mabashian]

@wenottingham so if you click on a running node to view the details I don't know that we have the info we need via the api to display the identifier. We'd need something that pointed back to the node in the summary_fields for the job. Maybe @AlanCoding knows if that's possible or not. If it was there we could certainly display it in the details.

[softwarefactory-project-zuul]

Build succeeded.

• awx-api-lint : SUCCESS in 2m 42s
• awx-api : SUCCESS in 6m 58s
• awx-ui : SUCCESS in 13m 28s
• awx-swagger : SUCCESS in 6m 55s
• awx-detect-schema-change : SUCCESS in 7m 47s (non-voting)
• awx-ansible-modules : SUCCESS in 3m 23s

[AlanCoding]

We already show the workflow job in the list view. I'd bet this query is poor performance, and I see no UI need for it in the list view. I digress.

We fully load the job's node before we can load the workflow. So as long as we are properly using the cache (we likely aren't), there is no performance impact for giving node details. identifier is a direct node field, so no worries there.

Answering the question, no technical blockers, but we should subject the view's performance to scrutiny (using the normal Django toolbar stuff) as we implement this.

[tiagodread]

The Node Alias is not available on job details but this is really cool, on hover over the node the user can see the Node Alias in addition to Resource Name

[tiagodread]

@mabashian once the rebase is done we can merge this one