Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use favicon for dev and prod builds #10388

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Use favicon for dev and prod builds #10388

merged 2 commits into from
Jun 9, 2021

Conversation

jakemcdermott
Copy link
Contributor

SUMMARY

@jakemcdermott jakemcdermott requested a review from mabashian June 8, 2021 13:03
@jakemcdermott jakemcdermott force-pushed the fix-favico branch 3 times, most recently from a066ada to 72608b0 Compare June 8, 2021 14:11
@ansible ansible deleted a comment from softwarefactory-project-zuul bot Jun 8, 2021
@ansible ansible deleted a comment from softwarefactory-project-zuul bot Jun 8, 2021
@ansible ansible deleted a comment from softwarefactory-project-zuul bot Jun 8, 2021
@jakemcdermott
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jakemcdermott jakemcdermott changed the title Use logo as favicon Use favicon for dev and prod builds Jun 8, 2021
@tiagodread
Copy link
Contributor

@akus062381 Look at <base_url>/favicon.ico, run dev and prod builds

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@akus062381
Copy link
Member

I spoke with @jakemcdermott and we established that, although this is working on prod/dev builds, opening a YOLO instance directly still shows the Ansible A as the icon instead of the red hat icon. putting back into needs _devel

@jakemcdermott
Copy link
Contributor Author

@akus062381 The issue should be resolved now. I sent some additional details your way. I believe this PR is ready for another look when you have a moment, thanks!

akus062381
akus062381 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@akus062381 akus062381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks :-)

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 122b36d into ansible:devel Jun 9, 2021
Spredzy added a commit to Spredzy/awx-operator that referenced this pull request Jun 14, 2021
@Spredzy
favicon: update path to favicon.ico
0b966b2 
Relates: ansible/awx#10388
Spredzy added a commit to Spredzy/awx-operator that referenced this pull request Jun 14, 2021
@Spredzy
favicon: update path to favicon.ico
d47d25b 
Relates: ansible/awx#10388
@Spredzy Spredzy mentioned this pull request Jun 14, 2021
Merged
@renovate renovate bot mentioned this pull request Jun 18, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akus062381 akus062381 akus062381 approved these changes

@mabashian mabashian mabashian approved these changes

Assignees

@akus062381 akus062381

Labels
component:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakemcdermott @tiagodread @akus062381 @mabashian