Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug where users were unable to click on text next to checkboxes/radios in modals #10279

Merged

Conversation

mabashian
Copy link
Member

SUMMARY

link #8852

This should impact lists in modals where the user can select one or more of the rows. They should now be able to click on the text/row in order to select. Examples:

row_select

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • UI

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nixocio
Copy link
Contributor

nixocio commented May 26, 2021

@mabashian this one will need a rebase. I also triggered an e2e test run.

@mabashian mabashian force-pushed the 8852-checkbox-list-item branch from fbb00c1 to 4b4e578 Compare May 27, 2021 14:50
@mabashian
Copy link
Member Author

This is now in a broken state after rebase because the component in question was refactored to our new list paradigm. I'll have to take another stab at it.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@tiagodread tiagodread self-assigned this May 27, 2021
@tiagodread
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@mabashian
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Copy link
Contributor

@tiagodread tiagodread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now one can select radio/checkbox clicking on the row inside modals

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants