Fix control plane EE image parameter #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation credentials
fosterseth
approved these changes
Apr 14, 2022
|
this looks good to me if it looks good to you @rooftopcellist |
rooftopcellist
approved these changes
Apr 15, 2022
|
Thank you for your contribution @kimbernator ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
control_plane_ee_imageis not read in until after the template that uses it has been rendered (this is done withinapp_credentials.yaml.j2which is called in "Apply Resources"). This change ensures that if said parameter is defined, it will be properly reflected in the app credentials secret.Resolves #821