Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize CSRF options #825

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

davidtluong
Copy link
Collaborator

Allow CSRF options to be customized, extra settings doesn't seem like it wouldn't work due to it being hard coded already in the configmap. Attached to JIRA.

@rooftopcellist
Copy link
Member

@rh-dluong Before merge, this PR needs the following:

  • These 2 parameters need to be added to the CRD (example)
  • They also needed to be added to the OLM parameters (example)
  • An addition to the README.md on usage

@davidtluong davidtluong force-pushed the csrf-custom branch 3 times, most recently from 3a6bb3d to f93e731 Compare April 12, 2022 16:28
@davidtluong
Copy link
Collaborator Author

I believe I've done all that was requested

@rooftopcellist rooftopcellist merged commit 1686875 into ansible:devel Apr 13, 2022
@rooftopcellist
Copy link
Member

Looks great, thank you for the contribution @rh-dluong !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants