Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "external_hostname" should not be required while using Route ingress #1807

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

TheRealHaoLiu
Copy link
Member

SUMMARY

Fix "external_hostname" should not be required while using Route ingress

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
ADDITIONAL INFORMATION

@fosterseth
Copy link
Member

we have a task that sets the external_hostname if ingress_type is "route"

- name: Set external_hostname
  set_fact:
    external_hostname: "{{ ingress.result.status.ingress[0].host }}"
  when: ingress_type | lower == 'route'

and in the jinja2 template it is only referenced under a {% if ingress_type|lower == "route" %} conditional

so not sure in which situation this wouldn't be defined when referenced.

@TheRealHaoLiu TheRealHaoLiu enabled auto-merge (squash) April 3, 2024 15:58
@TheRealHaoLiu
Copy link
Member Author

we have a task that sets the external_hostname if ingress_type is "route"

- name: Set external_hostname
  set_fact:
    external_hostname: "{{ ingress.result.status.ingress[0].host }}"
  when: ingress_type | lower == 'route'

and in the jinja2 template it is only referenced under a {% if ingress_type|lower == "route" %} conditional

so not sure in which situation this wouldn't be defined when referenced.

the task execute after the route is created

so bug affect all case when ingress_type=route

@fosterseth
Copy link
Member

ah didn't realize the ordering there, got it

@TheRealHaoLiu TheRealHaoLiu merged commit fcbf394 into ansible:devel Apr 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants