Do not cause web deployment restart on pre-stop scripts changes #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rooftopcellist
force-pushed
the
refine_checksum_annotations
branch
from
91be7f5 to
285adc8
Compare
|
Thanks @stanislav-zaprudskiy ~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a small change to remove unrelated checksum annotation from
webdeployment, as this deployment is not utilizing the corresponding referenced ConfigMap and thus should not be rolled out (restarted) whenever that changes.ISSUE TYPE
ADDITIONAL INFORMATION
The similar annotation changes will have to be provided in future, should it be ever decided that e.g. receptor certs/configs or projects PVC are no longer needed (both for
webandtaskdeployments). Likewise, when new mounts are added the annotations should be extended.