-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mkdocs scaffolding #1363
Add mkdocs scaffolding #1363
Conversation
To fix the warning, can you:
That should build a simple docsite with those two existing files. |
Okay looks like we can potentially get away without an index.md file if we follow what was done here -https://github.com/ansible/ansible-language-server/blob/main/mkdocs.yml |
@BhattacharjeeSutapa - the following as a requirements.txt file in the docs folder might help avoid having to do an apt install mkdocs... cairosvg Then a pip install -r requirements.txt might work instead of an apt install |
@oraNod - can you review this PR when you have the chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @BhattacharjeeSutapa I can build the site without error. One nit on the uri that allows direct edits on GitHub.
Should this PR include a title and maybe some starter text in "index.md"?
mkdocs.yml
Outdated
site_name: awx-operator | ||
site_url: https://awx-operator.readthedocs.io/ | ||
repo_url: https://github.com/ansible/awx-operator | ||
edit_uri: blob/main/docs/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit_uri: blob/main/docs/ | |
edit_uri: blob/devel/docs/ |
Looking good @BhattacharjeeSutapa One final nit is to move that requirements file into the docs directory ( |
Moved requirements.txt file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @BhattacharjeeSutapa
@BhattacharjeeSutapa hey I may not be online at the usual time tomorrow but looks like this PR is failing automated CI testing. In case it doesn't show the error, this is what I'm seeing: So basically it's saying on that line in the mkdocs.yml file, there is an extra whitespace that you need to delete. Thanks! |
@TheRealHaoLiu Hi, This PR adds docs scaffolding to build AWX Operator docs with MKDocs and is failing CI with an error related to molecule. Would you mind taking a look at that please? Not sure how to fix that. Thanks. |
Hi @samccann two whitespaces have been deleted. Sorry for late update. |
@BhattacharjeeSutapa - hey - it took me so long to get back to this that your branch now needs a rebase. If you're unfamiliar with rebasing in git, you can see the basics at https://docs.github.com/en/get-started/using-git/about-git-rebase and ping any of us on the Ansible docs matrix channel if you want more assistance. Note the main branch here is called devel so you'll be rebasing to that. For me, the typical steps are: Hopefully you don't get any merge conflicts but if you do, we can help you resolve them in matrix or here if you prefer. |
@BhattacharjeeSutapa - along with the rebase, can you also add the /site folder to the .gitignore? This will make sure git doesn't try to add the temporary /site files to anyone's PR after they do a mkdocs build. |
f1a2183
to
991b8ff
Compare
@BhattacharjeeSutapa Hi, there are two things needed to pass the Molecule CI tests. First thing is to lint the mkdoc.yaml file. It has a couple of undefined fields and a whitespace issue. I made the changes in this commit: oraNod@3133f24 You can cherry-pick that or do your own linting in something like VSCode (ctrl+i). The 2nd thing is that the docs requirements need to be updated. I've made the changes in this commit, feel free to cherry-pick them: oraNod@399a235 After that the Molecule tests should pass (I tested with a PR that includes your commits plus my two: https://github.com/ansible/awx-operator/actions/runs/5387656775/jobs/9779262790?pr=1469) Hope this helps! |
thanks @BhattacharjeeSutapa for working with us to get this merged! |
SUMMARY
Adding mkdocs scaffolding
Fixes #1359
ISSUE TYPE
So far I am hitting the following error when I try to build the docs locally.
Due to this error, when I open the page, it throws a 404 error. Any help is appreciated. For this reason, I have
strict: false
so that the site at least serves.