-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use sha1 instead of md5 to make the installer work in FIPS #1260
Conversation
@rooftopcellist @TheRealHaoLiu This is ready for review |
Ur wonderful! |
Thanks for the review @TheRealHaoLiu |
Thanks for following up and contributing this @ravitejb ! |
Thanks you guys. We where dealing since weeks to get the awx-operator working on our FIPS enabled environment. After dealing with FQCN's already this finally let us successfully install AWX. Also thanks for contributing this @ravitejb |
It might be wise to use something more future proof than SHA1. https://csrc.nist.gov/Projects/hash-functions SP 800-131 says SHA1 is acceptable for checksums. SHA2 and SHA3 are preferred. See page 18. https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-131Ar2.pdf |
Agree, I thought the same in the morning. We adopted it and it made us happy. Can we easily change it to a prefered one? |
I thought about adding It looks like SHA2/3 are not available with the version of hashlib we currently have. SHA256 is available, but seems like overkill, plus it is So I am inclined to leave it as is, or if anything, change it to However if this is a no-go for install, we could look at a newer python hashlib dep and see if that makes SHA2 availalble. But it seems like FIPS still allows SHA1's use for checksums. |
SUMMARY
New or Enhanced Feature
ISSUE TYPE
Use
SHA1
instead ofmd5
to make the installer work in FIPS mode.ADDITIONAL INFORMATION
Related to a new annotation added here: