Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] restore use k8s_cp module to read backup files #1212

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

JoelKle
Copy link
Contributor

@JoelKle JoelKle commented Feb 1, 2023

SUMMARY

Use the k8s_cp Ansible module to read the backup files if we restore AWX.
This simplifies the role.

As proposed from @rooftopcellist in #1111

ISSUE TYPE
  • New or Enhanced Feature
ADDITIONAL INFORMATION

My restore test was successful.

@TheRealHaoLiu
Copy link
Member

I like it, @jjwatt will do some manual test and maybe add some test automation for backup and restore

are you on our matrix chatroom? come join us! https://matrix.to/#/#awx:ansible.com

@TheRealHaoLiu TheRealHaoLiu self-assigned this Feb 8, 2023
@TheRealHaoLiu TheRealHaoLiu changed the title [feature] restore use k8s_cp module to read backup files [chore] restore use k8s_cp module to read backup files Feb 8, 2023
@JoelKle
Copy link
Contributor Author

JoelKle commented Feb 9, 2023

Thanks for the invitation. You can reach me @JoelKle:matrix.org
I hope i can keep up with the news :)

@rooftopcellist
Copy link
Member

@JoelKle Thanks for the contribution!

@jjwatt Here are some notes on how you can go about testing this out. Please reach out if you have any questions!

@rooftopcellist
Copy link
Member

I found a bug in the restore role while testing this:

But this is unrelated to this PR.

@rooftopcellist rooftopcellist merged commit 5c91bbd into ansible:devel Mar 22, 2023
@rooftopcellist
Copy link
Member

@JoelKle Thank you for following up on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants