Why image version in image name into the deployment

[Davidffry]

ISSUE TYPE

• Bug Report

SUMMARY

It seems, when we deploy awx that the image name with his version is inserting into the template.spec.containers[0].image : _ quay.io/ansible/awx-operator:0.15.0-11-g57aa585_

ENVIRONMENT

• AWX version: 0.15.0
• Operator version: 0.15.0
• Kubernetes version: 1.21.5
• AWX install method: WSL with docker desktop on Windows

STEPS TO REPRODUCE

Make deploy

EXPECTED RESULTS

...
** 32   template:
 33     metadata:
 34       creationTimestamp: null
 35       labels:
 36         control-plane: controller-manager
 37     spec:
 38       containers:
 39       - args:
 40         - --secure-listen-address=0.0.0.0:8443
 41         - --upstream=http://127.0.0.1:8080/
 42         - --logtostderr=true
 43         - --v=10
 44         image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0
 45         imagePullPolicy: IfNotPresent
 46         name: kube-rbac-proxy
 47         ports:
 48         - containerPort: 8443
 49           name: https
 50           protocol: TCP
 51         resources: {}
 52         terminationMessagePath: /dev/termination-log
 53         terminationMessagePolicy: File
 54       - args:
 55         - --health-probe-bind-address=:6789
 56         - --metrics-bind-address=127.0.0.1:8080
 57         - --leader-elect
 58         - --leader-election-id=awx-operator
 59         env:
 60         - name: ANSIBLE_GATHERING
 61           value: explicit
 62         - name: ANSIBLE_DEBUG_LOGS
 63           value: "false"
 64         - name: WATCH_NAMESPACE
 65           valueFrom:
 66             fieldRef:
 67               apiVersion: v1
 68               fieldPath: metadata.namespace
 69         image: quay.io/ansible/awx-operator:0.15.0
 70         imagePullPolicy: IfNotPresent**
...

ACTUAL RESULTS

...
** 32   template:
 33     metadata:
 34       creationTimestamp: null
 35       labels:
 36         control-plane: controller-manager
 37     spec:
 38       containers:
 39       - args:
 40         - --secure-listen-address=0.0.0.0:8443
 41         - --upstream=http://127.0.0.1:8080/
 42         - --logtostderr=true
 43         - --v=10
 44         image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0
 45         imagePullPolicy: IfNotPresent
 46         name: kube-rbac-proxy
 47         ports:
 48         - containerPort: 8443
 49           name: https
 50           protocol: TCP
 51         resources: {}
 52         terminationMessagePath: /dev/termination-log
 53         terminationMessagePolicy: File
 54       - args:
 55         - --health-probe-bind-address=:6789
 56         - --metrics-bind-address=127.0.0.1:8080
 57         - --leader-elect
 58         - --leader-election-id=awx-operator
 59         env:
 60         - name: ANSIBLE_GATHERING
 61           value: explicit
 62         - name: ANSIBLE_DEBUG_LOGS
 63           value: "false"
 64         - name: WATCH_NAMESPACE
 65           valueFrom:
 66             fieldRef:
 67               apiVersion: v1
 68               fieldPath: metadata.namespace
 69         image: quay.io/ansible/awx-operator:0.15.0-11-g57aa585
 70         imagePullPolicy: IfNotPresent**

##### ADDITIONAL INFORMATION

No.

##### AWX-OPERATOR LOGS

No.

[hungtran84]

Actually, you need to check out the specific release (tag) then Makefile will extract the version number from there.

VERSION ?= $(shell git describe --tags)

@shanemcd already mentioned it in the guideline

Now you need to deploy AWX Operator into your cluster. Clone this repo and `git checkout` the latest version from https://github.com/ansible/awx-operator/releases, and then run....

Otherwise you end up with the latest version (including commit hash, i guess).

[Davidffry]

Ok I understand, after translate the docs, maybe, I suggest to write it more cleary into the doc like or an example :

$ git checkout $(git describe --tags `git rev-list --tags --max-count=1`)

Or for each release update change the README.md.

$ git checkout 0.15.0 #if you like to change the release

Or
Display list of release into the doc.
I make an pull Request #669. You can cancel it if you want ;)
Thanks for your work. ;)

[shanemcd]

Ultimately we want to remove the need for running make. See #657