-
Notifications
You must be signed in to change notification settings - Fork 23.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql_db: add dump_extra_args parameter #67747
Merged
felixfontein
merged 2 commits into
ansible:devel
from
Andersson007:mysql_db_dump_extra_args
Feb 25, 2020
Merged
mysql_db: add dump_extra_args parameter #67747
felixfontein
merged 2 commits into
ansible:devel
from
Andersson007:mysql_db_dump_extra_args
Feb 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.10
This issue/PR affects Ansible v2.10
community_review
In order to be merged, this PR must follow the community review workflow.
database
Database category
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
mysql
needs_triage
Needs a first human triage before being processed.
support:community
This issue/PR relates to code supported by the Ansible community.
test
This PR relates to tests.
labels
Feb 25, 2020
ready_for_review |
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
community_review
In order to be merged, this PR must follow the community review workflow.
labels
Feb 25, 2020
felixfontein
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@felixfontein thanks for reviewing and merging! |
sivel
removed
the
needs_triage
Needs a first human triage before being processed.
label
Feb 25, 2020
CWollinger
added a commit
to CWollinger/ansible
that referenced
this pull request
Mar 18, 2020
* Add note that devel branch should not be used in real environments (#67483) * ovirt_disk: correct description of storage_domain (#67454) * ovirt_disk: correct description of storage_domain * add changelog Signed-off-by: mnecas <[email protected]> Co-authored-by: Abhijeet Kasurde <[email protected]> * [aws_s3] fix deleting versioned objects before deleting bucket (#54435) * [aws_s3] fix deleting the current objects and the previous versions from a version-enabled bucket * use existing paginated_list function to keep compatibility with the other places it is called * changelog * Add noteworthy change to the porting guide * Reword that with acozine's suggestion Co-authored-by: Alicia Cozine <[email protected]> * Disable failing zabbix_user test. (#67487) * Disable zabbix_user test on aix. * Disable failing zabbix_user test. * Clarify b64encode with Python 2 (#67488) * Update windows_faq.rst (#67482) Steers users around the error: Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '/usr/local/lib/python2.7/dist-packages/xmltodict.py' Consider using the `--user` option or check the permissions. --> * Fix bug in iam_role - _list_policies was not returning anything (#67495) * Restore AIX tests in CI. * Rebalance Windows groups for devel run (#67496) * ansible-galaxy - fix role list bug (#67391) Properly list roles even when the role name is the same or a substring of the path to the role. * Add SimpleUpdate command (#65074) * add SimpleUpdate command * add AllowableValues check for Targets property * Specify lowercase only for Galaxy namespaces (#67485) * specify lowercase only for galaxy namespaces * doh... include meta file * Windows: Add multi-domain forest Support (#65138) * Add multi-domain forest Support cloned extra_args so there is no check for credentials needed. Fixed Formatting added missing extra_args to pure state * minor Fixes do not clone $extra_member_args again do not overide $name better description * added Changelog fixed typo in Documentation * [doc] Set consistent return codes for modules (#67444) Set consistent possible return codes for these similar two modules. * Win tests - prepare for collection migration in tests (#67506) * Update URLs in documentation (#67376) Partially fixes: #67357 Signed-off-by: Abhijeet Kasurde <[email protected]> * Fix links in Postgresql modules (#67511) Signed-off-by: Abhijeet Kasurde <[email protected]> * route53: improve octal encoded characters handling (#60508) * route53: improve octal encoded characters handling * Update changelogs/fragments/60508-route53-improve-octal-characters-handling.yml Co-Authored-By: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> * openssl_* modules: prevent crash on fingerprint determination in FIPS mode (#67515) * openssl_* modules: prevent crash on fingerprint determination in FIPS mode. * Add changelog. * postgresql_info module: fix broken link (#67517) * facts virtual: detect KVM when product_name is 'KVM Server' (#66780) * facts virtual: detect KVM when product_name is 'KVM Server' * added changelog fragment for "facts virtual: detect KVM when product_name is 'KVM Server'" * Replace 'message' in module parameters (#60051) * 'message' parameter is replaced by 'commit_message' in grafana_dashboard * 'message' parameter is replaced by 'notification_message' in datadog_monitor This change is required since 'message' as parameter name is used internally by Ansible core engine. Fixes: #39295 #45362 #47132 #59617 Signed-off-by: Abhijeet Kasurde <[email protected]> * Vyos static route module added (#62193) * Vyos static route module added Signed-off-by: rohitthakur2590 <[email protected]> * sanity fixes Signed-off-by: rohitthakur2590 <[email protected]> * empty config traceback fix Signed-off-by: rohitthakur2590 <[email protected]> * sanity check fix * model specific changes and SI test cases updated Signed-off-by: rohitthakur2590 <[email protected]> * new state changes and SI test cases updated Signed-off-by: rohitthakur2590 <[email protected]> * sanity fixes Signed-off-by: rohitthakur2590 <[email protected]> * UT cases added Signed-off-by: rohitthakur2590 <[email protected]> * replaced operation fix Signed-off-by: rohitthakur2590 <[email protected]> * review comments incorporated Signed-off-by: rohitthakur2590 <[email protected]> * shippable fix Signed-off-by: rohitthakur2590 <[email protected]> * sanity fix Signed-off-by: rohitthakur2590 <[email protected]> * delete opr updated Signed-off-by: rohitthakur2590 <[email protected]> * comments incorporated Signed-off-by: rohitthakur2590 <[email protected]> * Attempt to rebalance the aws tests (#67523) * pause - add missing interpreter line (#67134) * Update win_service example in win_nssm (#67530) `user` should be `username` for use in `win_service`, see https://docs.ansible.com/ansible/latest/modules/win_service_module.html#parameter-username * Fixed documentation for elb_target_group module to match the code logic. (#66689) * Add x509_crl module (#63435) * Add x509_crl module. * Add integration tests. * Fix some errors. * Fix inversion. * Compare name instead of tpye. * Fix fail_json() calls. * Work around rename of serial_number attribute for cryptography 1.4. * Don't die for non-cert loading errors. * One more. * Fix function call. * Fixed/improved descriptions. * Don't read issuer from certificate file. * Allow to ignore timestamps. * Default value for revocation_date. * Update tests. * Mention ignore_timestamps in update docs. * Support privatekey_content, and require some options only if state is present. * Allow to pass certificate in directly. * Add tests. * Fix required_if. * Forgot to encode content. * Forgot to adjust type. * Allow to return CRL's content directly. * return_crl_content -> return_content (as in #65400). * Fix elements. * Fix messages. * Use required_one_of and mutually_exclusive instead of doing the checks by hand. * Fix format. * Skip tests on AIX. * Fix typo. * Fix KeyError for iSCSI parameters (#67463) The required parameters for the LUN mapping for destination LUN is address, port and iqn. However if the user doesn't pass parameters like CHAP authentication parameters, we will get KeyError. The patch fixes the same. * Allow botocore configuration for aws modules (#55217) * Allow botocore configuration to be configurable for boto3 modules * Allow modification of the boto user agent * play nicely with modules that might be modifying config * changelog * Rename callback_retry_task_name test. Avoid confusion with other `callback_` prefixed tests. * Update digital_ocean_droplet.py (#65251) * Move scaleway_s3 tests to the legacy directory. These tests rely on the AWS S3 modules, but will not be migrated along with those modules into an AWS collection. Since these tests will not reside in a collection alongside the modules under test they are being moved to the legacy tests directory. The legacy tests directory will soon be migrated to a separate repository. * openssl_* / x509_* modules: refactoring (#67540) * Move common code to module_utils. * Unify get_relative_time_option. * doc fragment needs proper types (#67545) * win_credential - fix wildcard name (#67549) * Remove unused imports for vyos (#67550) These flake8 errors would caught in our collection testing. Signed-off-by: Paul Belanger <[email protected]> * Add iosxr_acl_interfaces RM (#66936) Signed-off-by: NilashishC <[email protected]> * IOS: Add voice vlan to ios_l2_interfaces (#67211) * Add voice vlan to ios_l2_interfaces * Fixed pep8 issues, added voice vlan to tests, updated module docs * add omit_date option for template dump (#67302) * added omit_date option for template dump omit_date=yes removed the date field in the exported template * Update zabbix_template.py - ansibot fixes - better function call handling * Update zabbix_template_info.py * Create 67302-zabbix_template_info-add-omit_date-field * Rename 67302-zabbix_template_info-add-omit_date-field to 67302-zabbix_template_info-add-omit_date-field.yml * postgresql_subscription: remove stat (#67470) * zabbix: new module zabbix_host_events_info (#56162) * Specify priority for VMs in Azure VM scale sets (#65226) Adds support to create VMSS with low-priority VMs through a new optional parameter. The default is to create a VMSS with Regular priority VMs. https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-use-low-priority for details. * vmware_guest_disk storage DRS bugfix for get_recommended_datas… (#67221) * Fix sDRS recommendations Fixes storage DRS recommendation call for add disk scenario * Undo changes to whitespacing * Undo changes to whitespacing (pt. 2) * Add datastore_cluster prop to disk defaults * Create 67221-vmware-guest-disk-storage-drs-fix.yml * Collection developer guide - BOTMETA (#67538) * Docs: Improve how to migrate and create collections * Update docs/docsite/rst/dev_guide/developing_collections.rst Co-Authored-By: Alicia Cozine <[email protected]> * New module ec2_tag_info - fetch the tags from EC2 objects (#66839) * New module ec2_tag_info - fetch the tags from EC2 objects * Add ec2_tag_info to group/aws * Add basic test case * Fix hacking policy (#67579) * regex_replace multiline support (#65051) * document multiline parameter for regex_replace * add changelog fragment * tests for regex_replace_multiline * openssl_* modules: improve test robustness (#67568) * Run Ed25519 and Ed448 tests for openssl_csr and openssl_certificate only if key generation succeeded. * Make openssl_privatekey tests more robust: allow special key generation tests to fail with 'algorithm not supported' on FreeBSD. * Module validation: sanity check mutually_exclusive, required_if, required_xxx ... (#66961) * required_if checks should have three or four parts. * Validate mutually_exclusive, required_together, required_one_of, required_if and required_by. * Simplify code. * Improve messages. * Add changelog. * Sanity check. * Update docs. * Update ignore.txt. * Don't continue with tests when terms are not strings. * Remove ignore.txt entry. * Make sure validate-modules doesn't choke on things already flagged by schema test. * Check required_if requirements list for strings. * Relocate Shippable tools. (#67556) * Move Shippable tools to hacking directory. These limits the `test/utils/shippable/` directory to scripts required for CI. * Fix `test/utils/shippable/` file classification. * Update package-data sanity test. * fix indents of EOS Platform Options (#67564) * Update win_dsc.py (#67563) * Adding nanvault to Other Tools list (#67583) ##### SUMMARY Adding nanvault - a standalone tool to encrypt and decrypt files in the Ansible Vault format, featuring UNIX-style composability. ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr * ec2_tag - Deprecate the use of state=list (#66840) * ec2_tag - Deprecate the use of state=list * Update lib/ansible/modules/cloud/amazon/ec2_tag.py * Add changelog and porting_guide entries Co-authored-by: flowerysong <[email protected]> * cloudfront_distribution: Always add field_level_encryption_id to cache behaviour (#61271) * cloudfront_distribution: (integration tests) Migrate to using module_defaults * cloudfront_distribution: (integration tests) Use the ID rather than the alias Using aliases requires providing a valid SSL certificate, as such we're not longer able to test using an arbitrary hostname * cloudfront_distribution: (integration tests) Make sure we delete the test s3 bucket when tests fail * cloudfront_distribution: field_level_encryption_id is now a mandatory field always add it Setting the field to an empty string has the same effect as the original behaviour. * Copy & Paste fixup Co-Authored-By: Jill R <[email protected]> Co-authored-by: Jill R <[email protected]> * Add warning when running devel (#67502) * Add warning when running devel. Addresses #67362 * Add config entry to disable devel warning, so it doesn't impact CI * Update warning about using devel * Templating: make sure only one variable results are cached (#67429) * Make sure only one variable results are cached. * Add changelog. * Add test. * Fix typo with devel warning config option (#67590) * Remove unused import for iosxr acl_interfaces (#67587) Signed-off-by: Paul Belanger <[email protected]> * Use Ansible to load ps module utils in arg spec checker (#67596) * Use Ansible to load ps module utils in arg spec checker * Added changelog and note * Add create_option to disk definitions (#62357) Add create_option parameter to disk definitions to control whether disks are created from the base image or are new disks being added to the VMs. Currently, custom images with data disks defined in the image cannot be used to launch VMs unless data disk definitions are excluded. This prevents the data disks from being modified/extended (like selecting a different SKU or making the data disks bigger). Exposing this option allows VMSS VMs to be created with base images that have data disks while extending their definitions. Addresses #61804 * postgresql_info: add subscription info (#67464) * postgresql_info: add subscription info * add changelog * Refactor aws_kms to bring down the complexity score (#66037) * Remove dead code key_matches_filter/key_matches_filters * Fail more cleanly when we don't recognise the 'shape' of KMS policy * Refactor aws_kms to bring down the complexity * Minor docs tweaks * Changelog fragment * Fixups from review * Remove unused import for six in ipaddr filter (#67595) This was caught in our ansible.netcommon collection testing. Signed-off-by: Paul Belanger <[email protected]> * Do not error if collection specified null dependencies (#67575) * Spelling fix, win_chocolatey_facts.py (#67617) Spelling fix - "path" not "pth" * Purestorage content migration botmeta (#67189) * Adding content migration for purestorage flasharray modules * Adding content migration for purestorage flashblade modules * Allow SSH synchronization between Docker containers * Add changelog * Fix become for network_cli in collections. * elb_target / elb_target_info : Integration test fixups (#61256) * Update AWS policy to enable management of TargetGroups * elb_target: (integration tests) migrate to using module_defaults * elb_target: (integration tests) lookup the AMI by name rather than hard coding AMI IDs * elb_target_info: (integration tests) finish rename of integration test role * elb_target: (integration tests) rename various resources to consistently use {{ resource_prefix }} * elb_target_info: (integration tests) Migrate to using module_defaults * elb_target_info: (integration tests) Lookup AMI by name rather than hard coding AMI IDs * Apply suggestions from code review Co-Authored-By: Jill R <[email protected]> * elb_target: (integration tests) Remove the 'unsupported' alias * Try bumping up the timeout * Rules don't permit 'shippable' (resource_prefix uses this when run in shippable) * Try bumping up more timeouts :/ * Avoid double evaluation of target_health assertion * Simplify target_type usage a little (rather than constantly performing a lookup) * mark elb_target tests 'unstable' for now, they're slow Co-authored-by: Jill R <[email protected]> * sns_topic ensure "changed" works as expected when managing delivery policies (#60944) * sns_topic: (integration tests) Move the tests over to using module defaults * sns_topic: (integration tests) Add test for behaviour of changed when using delivery_policy * sns_topic: ensure "changed" behaves properly when managing delivery policies - a delivery_policy isn't an IAM policy, so compare_policies didn't cope with it - AWS automatically adds an additional option when you set an HTTP delivery policy * Parse the delivery policies so we can test the changes properly * Fix runas as collection become plugin (#67638) * Some cloudengine modules miss "import __future__" and "mateclass", update to add them. (#67635) * update doc, missing future & metaclass type. * update ignore.txt * add a changelog. * update changelog. * rename changelog. * update changelog. * /docs/docsite/rst/dev_guide: fix typos (#67643) * user_guide/intro_adhoc.rst: fix typo (#67644) * dev_guide/developing_modules_best_practices.rst: fix typo (#67639) * docs/docsite/rst/: fix typos (#67645) * Update AWS modules that use to implicitly retry on NotFound errors (#67369) * Update AWS modules that expect to retry on exception codes that match the regex '^\w+.NotFound' Modules should intentionally define any extra error codes Use a waiter for ec2_vpc_igw after creating an internet gateway instead of retrying on InvalidInternetGatewayID.NotFound * eos : Add resource module eos_acl_interfaces (#67137) * Added fix for bug # 54400 * Adding files for RM static_routes * Added Integration tests * Revert "Added fix for bug # 54400" This reverts commit bf42db42697d64abbfea4e546f890637d4a5175b. * Revert "Adding files for RM static_routes" This reverts commit dafdd92d4327cfc6dfcebb1e977454b2f77a1daa. * Revert "Added Integration tests" This reverts commit 129dc87682bba9292105fc3b642fdf3930ce79fd. * Adding files for RM static_routes * Added Integration tests * Corrected lint errors * Added fix for bug # 54400 * Revert "Added fix for bug # 54400" This reverts commit bf42db42697d64abbfea4e546f890637d4a5175b. * Revert "Adding files for RM static_routes" This reverts commit dafdd92d4327cfc6dfcebb1e977454b2f77a1daa. * Revert "Added Integration tests" This reverts commit 129dc87682bba9292105fc3b642fdf3930ce79fd. * acl_interfaces * acl_interfaces in progress * Adding unit testcases * Addresses Paul's review comments * worked on shippable errors * indentation errors * Modified unit tests * indent issues * indent issues * eos specfic changes * making the integration tcs skip the zuul run * addressed review comments * added required:True documentaiton * fix(scaleway): use jsonify for application/json content-type only (#66957) * fix(scaleway): use jsonify for application/json content-type * add changelog * Test: Bump Tower version to latest release * AnsibleAWSModule add 'region' method (#66988) * Add get_aws_region to module_utils.ec2 and region to AnsibleAWSModule * Add example use * Add changelog * copy: ensure _original_basename is set: fixes #47050 (#47238) * fixed #47050 * added changelog fragment * added quick and basic test * Revert "added quick and basic test" This reverts commit 75f4141656635841d4ce18994667e3b44b7b1289. * added better tests * now also creating files to copy on the remote * removed tests for recursive copying which is not supported by remote_src * Support private test plugins in ansible-test. (#67660) * Support private test plugins in ansible-test. This feature is exclusively used for testing Ansible itself and is not available to collections. Content in the newly supported directories will be added in follow-up PRs. * Add new directory to path classification. * Support new paths in shebang test. * Add new directory to manifest. * Show field instead of value (#59926) * Show argument name vs value on failed conversion generally more useful to user as they might set values indirectly * clog * Fix network setup for collections in ansible-test. * Handle NoneType error in vmware_host_service_info (#67641) Handle NoneType error occured due to accessing host system service info in vmware_host_service_info module. Fixes: #67615 Signed-off-by: Abhijeet Kasurde <[email protected]> * Some cloudengine modules miss "import __future__" and "mateclass", update to add them. (#67634) * update doc missing future & mateclass. * update ignore.txt. * add a changelog. * update changelog. * Fix up network testing on Shippable. (#67678) This prepares for code coverage collection for initial setup of incidental test coverage. * Split vyos tests to avoid timeouts with coverage. * Split hcloud tests into two CI groups. (#67683) * Split hcloud tests into two CI groups. This will hopefully resolve CI failures when running with code coverage. * Fix smoketest logic. * scaleway_compute: check image on get instead of list (#67655) * fix scaleway_compute: check image on get instead of list * add changelog Signed-off-by: Alexis Camilleri <[email protected]> * ovirt_vm: correct numa nodes (#67611) * init commit * update docs * update numa function name * correct whitespaces * Fixes nxos_l2_interfaces module traceback if allowed vlans are not preconfigured (#67457) * fixes 67455 * fix review * Fix to - nxos_lag_interfaces not idempotent (#67359) * Added fix for bug # 54400 * Adding files for RM static_routes * Added Integration tests * Revert "Added fix for bug # 54400" This reverts commit bf42db42697d64abbfea4e546f890637d4a5175b. * Revert "Adding files for RM static_routes" This reverts commit dafdd92d4327cfc6dfcebb1e977454b2f77a1daa. * Revert "Added Integration tests" This reverts commit 129dc87682bba9292105fc3b642fdf3930ce79fd. * Adding files for RM static_routes * Added Integration tests * Corrected lint errors * Added fix for bug # 54400 * Revert "Added fix for bug # 54400" This reverts commit bf42db42697d64abbfea4e546f890637d4a5175b. * Revert "Adding files for RM static_routes" This reverts commit dafdd92d4327cfc6dfcebb1e977454b2f77a1daa. * Revert "Added Integration tests" This reverts commit 129dc87682bba9292105fc3b642fdf3930ce79fd. * Fix to #67169 * corrected rebase spillover * indentation errors fixed * modified integration testcase * Add iosxr_acls RM (#66207) Signed-off-by: NilashishC <[email protected]> * VyOS: firewall global module added (#66800) * firewall global module Signed-off-by: rohitthakur2590 <[email protected]> * sanity fixed Signed-off-by: rohitthakur2590 <[email protected]> * test updated Signed-off-by: rohitthakur2590 <[email protected]> * sanity fixes Signed-off-by: rohitthakur2590 <[email protected]> * group member handling updated Signed-off-by: rohitthakur2590 <[email protected]> * comments incorporated Signed-off-by: rohitthakur2590 <[email protected]> * lib/ansible/plugins/inventory/ini.py: added spacing for error message (#67361) Signed-off-by: James McClune <[email protected]> * Fix flake8 errors with eos_acl_interfaces (#67695) Theses were exposed by our collections testing. Signed-off-by: Paul Belanger <[email protected]> * eos_acls : Add eos acls resource module (#66308) * Adding files for RM static_routes * Added Integration tests * Added Unit testcases * Addressed review comments * corrected lint errors * corrected documentation errors * Lint errors * corrected test/sanity * corrected documentation for deprecation * corrected case sensitivity * Again Documentation eroor * Lint errors again * corrected deprecated module in ignoretxt * added new gethered,rendered,parsed state checks to unit test * New code broke the old flow-fixed * Lint errs * Added check for running_config * eos_acls resource module added * Corrected errors * corrected documentation errors * corrected typo * Testcases in progress * Integration tests in progress * Integration tests * Added Intergration tcs * Corrected pylint errors * Resolving issues due to rebase * Corrected Typo * more pylint errors * more pylint errors * more pylint errors * Documentation * Documentation * More lint errors * Fixed Indentation * Indentation issues - not getting fixed * Indentation issues - not getting fixed * Added rtt testcase * Corrected whitespaces * addressed review comments * moved integration tests to common - to support eapi tests * modification for merge update * indentation errors * added line key * Fixing shippable errors * fixing doc errors * fixing doc errors * fixing doc errors * fixing doc errors * fixing indentation * modified replaced operation * rebase issue fixed * Corrected typo * review comments and flake8 error fixed * Remove unused DCI script * Fix wakeonlan test for newer FreeBSD (#67656) * Specify display width and no color in test_execute_list_collection_no_valid_paths (#67680) This ensures the test passes regardless of the test environment. Previously, it would pass in some environments but fail locally in other environments, due to the width being calculated as different or support for color not being consistently detected. Signed-off-by: Rick Elrod <[email protected]> * updated single quote handling to not strip and error on odd number (#67500) Fixes #67274 * Make AWS test plugin to refer to the aws-permissions-for-integration-tests (#67665) Make AWS test plugin to refer to the aws-permissions-for-integration-tests section of the AWS devel docs now that we have them, rather than suggesting to flag down specific users. * Skip lookup_hashi_vault test for Python 2.6 (#67657) * Migrate a batch of AWS modules to AnsibleAWSModule (1) (#67191) * Move various Amazon modules over to AnsibleAWSModule * Remove HAS_BOTO3 logic, it's handled by AnsibleAWSModule * Simplify argument_spec handling ec2_argument_spec is automatically added by AnsibleAWSModule * Cleanup boto3 error handling using fail_json_aws * Migrate simple cases from boto3_conn to module.client() * Migrate batch modules over to module.client() * Migrate EFS module over to module.client() * Comment cleanup * Use deprecated_aliases in argument_spec rather than custom code * Cleanup unused imports * Make use of module.region * Deprecate batch.AWSConnection it's now dead code * change intelligence_pack to intelligence_packs (#67686) * Change package_license to accept_license (#67676) * fixes link, makes intrapage TOC local (#67664) * adds missing alias to win_regedit documentation (#67662) * Update example requirements file docs (#67626) Use "name" when possible rather than "src" to make the examples of roles and collections in a single requirements files more coherenant. Fundamentally, roles and collections are completely different. But we can make the requiremets file easier to read by unifying the format as much as possible. * ovirt_vm: add cpu_pinning example (#67612) * Setup documentation - windows custom fact variable name (#67690) * s3_bucket: accept NetApp StorageGRID create_bucket response. (#67462) * Remove unused imports from vyos_firewall_global (#67710) Signed-off-by: Paul Belanger <[email protected]> * Remove unused imports in eos_modules unittest (#67709) Signed-off-by: Paul Belanger <[email protected]> * add download tarball option (#67548) * Remove unused imports for iosxr_acls (#67711) Signed-off-by: Paul Belanger <[email protected]> * First batch of incidental integration tests. (#67717) * Initial copy of incidental network tests. * Update incidental test aliases. * Add incidental tests to CI. * Rewrite module references in tests. This should not be necessary once module redirection is supported. * Rewrite target references for renamed targets. * Add support collections for incidental tests. * Add ignores for test support code. * Remove echo used for debugging. * Remove unnecessary indent (#67728) total_size fact is populated if schema is not specified in postgresql_user_obj_stat_info module. Signed-off-by: Abhijeet Kasurde <[email protected]> * eos static_routes module added (#65480) * Adding files for RM static_routes * Added Integration tests * Added Unit testcases * Addressed review comments * corrected lint errors * corrected documentation errors * Lint errors * corrected test/sanity * corrected documentation for deprecation * corrected case sensitivity * Again Documentation eroor * Lint errors again * corrected deprecated module in ignoretxt * added new gethered,rendered,parsed state checks to unit test * New code broke the old flow-fixed * Lint errs * Added check for running_config * Add rtt testcase * Fixed unit tcs * lint errors * lint errors * Modified replaced operation behavior * updated documentation and tests for delete opration * fixed shippable errors * review comments and flake8 error fix * syntax errors fixed * strip spaces for each value in host list lists (#67701) * Add an example of specifying a specific commit hash. (#67722) * Fix inline vaults for plugins in ensure_type (#67492) * Fix implicit string - only looked right because of the vault __repr__ * Add tests for strings and implicit strings * Remove unused variables in collection API (#67724) Remove unused variables in _download_file API Signed-off-by: Abhijeet Kasurde <[email protected]> * mysql_db: add dump_extra_args parameter (#67747) * mysql_db: add dump_extra_args parameter * add changelog fragment * postgresql_info: add getting publication statistics (#67614) * postgresql_info: add getting publication statistics * add changelog * fix * fix server_version check * add key rotation option to aws_kms (#67651) * add key rotation option * add changelog fragment * provide version added as string * change changelog to minor_changes * Update changelogs/fragments/67651-aws-kms-key-rotation.yml Co-Authored-By: Mark Chappell <[email protected]> * Update lib/ansible/modules/cloud/amazon/aws_kms.py Co-Authored-By: Mark Chappell <[email protected]> * prevent key upgrade if key rotation was enabled manually. In that case, the key rotation would be disabled, if not mentioned in the playbook * Update lib/ansible/modules/cloud/amazon/aws_kms.py Co-Authored-By: Mark Chappell <[email protected]> * Update lib/ansible/modules/cloud/amazon/aws_kms.py Co-Authored-By: Mark Chappell <[email protected]> * Update lib/ansible/modules/cloud/amazon/aws_kms.py Co-Authored-By: Mark Chappell <[email protected]> Co-authored-by: Mark Chappell <[email protected]> * aws_acm Add additional AWSRetry error codes (#67671) * Cleanup tests * Auto-Retry on ResourceNotFound and RequestInProgress exceptions * Use AnsibleModule options for required_if logic * changelog * Remove (now) duplicate RequestInProgressException catching * Allow a single retry when attempting to fetch the information about a cert directly after deleting it. There is a small chance that it goes away while we pull the details. * mysql_info: remove irrelevant comment (#67753) * win_dns_record: Improve examples documentation (#67744) * Update 'server' doc in nsupdate module to avoid DNS names (#67597) * adhoc: Load callbacks before sending v2_playbook_on_start (#67673) * Clean up CONDITIONAL_BARE_VARS warning. Fixes #67735 (#67751) * Test the delay option in wait_for_connection. * Second batch of incidental integration tests. (#67765) * Update incidental test aliases. * Rewrite target references for renamed targets. * Add incidental tests to CI. * Update sanity tests for incidental cloud tests. * Initial copy of incidental tests. * Copy contrib files into test. * Update paths in test. * Add support plugins. * Update plugin to work around missing deps. * Update sanity ignores. * Fix matrix entries. * Remove debug echo. * Fix to remove unnecessary duplicate line (#67761) * Fix to be support for zabbix 4.4 or more and python3 (#67693) add fragments file * Remove unused import from test_eos_static_routes.py (#67776) Signed-off-by: Paul Belanger <[email protected]> * misc typo fixes (#67775) Signed-off-by: Abhijeet Kasurde <[email protected]> * ec2_instance - update tests related to termination protection (#65035) * ec2_instance - update tests related to termination protection * add more test cases for termination protection * Add more bot notifications for test related paths. * Add Switchport mode support in newly introduced *_l2_interfaces resource module (#67456) * fixes 65032 * Migrate ovirt to collection - add botmeta (#67729) * Add ovirt migrated_to to botmeta * list all ovirt modules * remove .idea * remove links * Remove `test/legacy/` directory. (#67786) * Remove `test/legacy/` directory. * Remove references to `test/legacy/` directory. * Update the remaining valid legacy reference. * Remove outdated legacy references. * postgresql_info: move subscription info to corresponding database dict (#67772) * Remove unused import from frr cli plugin (#67790) Signed-off-by: Paul Belanger <[email protected]> * Mark aws_acm unstable and connection_aws_ssm disabled (#67787) * Mark aws_acm and connection_aws_ssm unstable CI failures in https://app.shippable.com/github/ansible/ansible/runs/160867/133/tests and https://app.shippable.com/github/ansible/ansible/runs/160867/129/tests * Disabling concection_aws_ssm, it's repeatedly failing on this PR https://app.shippable.com/github/ansible/ansible/runs/160888/133/tests * Reflect changed JSON structure than zabbix version 4.4 or more to zabbix_user add fragments file Fix several pointed out https://github.com/ansible/ansible/pull/67475#discussion_r380528775 https://github.com/ansible/ansible/pull/67475#discussion_r380532685 Enable integration test * read enabled_key_rotation status also in aws_kms_info (#67770) * read enabled_key_rotation status * add changelog * use AWSRetry decorator to prevent api rate limits * fix pip8 * s3_bucket - cleanup and test stabilisation. (#66778) * AnsibleAWSModule related cleanup - s3_bucket * Add extra information to s3_bucket timeout failures, it's possible the comparisons are doing something weird... * Move Bucket Encryption boto support logic into the pre-flight checks * Use the built in required_by logic * Rework s3_bucket integration tests * Add a retry around put_bucket_encryption s3_client.put_bucket_encryption is occasionally dropped on the floor by Amazon add some logic to retry s3_client.put_bucket_encryption call * Catch OperationAborted and retry, it is caused by a conflicting change still being in progress. (For example an Encryption setting applying) * Make sure we don't explode if the botocore version's too old * Review tweaks * mongodb_shard: fix doc formatting (#67750) * Add win_psrepository_info module (#67594) * Add win_psrepository_info module * Change return type * Add tests for win_psrepository_info * Add iosxr_static_routes RM (#65181) Signed-off-by: NilashishC <[email protected]> * Fix invalid botmeta entries (#67785) Correct paths Remove trailing whitespace * influxdb: Fix documentation (#67807) Signed-off-by: Abhijeet Kasurde <[email protected]> * mysql_db: add possibility to make dump with --no-create-db option (#67767) * mysql_db: add possibility to make dump with --no-create-db option * add changelog fragment * fix * Allow passing through of (almost) all params available … (#58118) * Allow passing through of (almost) all params available on boto methods in aws_api_gateway * Linting and docs fixes * Refactored method signature of create_deployment() to use keyword args instead of named args * Updated version_added flags to 2.10 * Cleanup and improve aws_api__gateway integration test play. Also included new params into test. * Fixed RETURN docs and some ttests * Completed RETURN docs and made integration tests match * Fixed variable names in test and YAML syntax in docs * Comment out critical sections of integration test * Fixed update test after figuring out what the error message means. Also updated error message to be more descriptive. * Fixed test assertion * Update docs and make tests reflect that endpoint type wont be changed on updates * Syntax fix * Add changelog fragment * Improve aws_api_gateway docs, fix typos. * Quote doc lines with colon * add module cloudformation_exports (#67349) * add module cloudformation_exports * add RETURN, add aliases group, clean up yaml * update return value. uncomment security_token. remove cloudformation shortcut * fix typo * try to delete test stack * rename stack * add cleanup and assert. try to set stack name with variable * create s3 bucket instead * set bucket name * add tests, remove unsed key and import, add iam role, add to module_defaults * import exceptions, fix assert syntax * fix assert * Update test/integration/targets/cloudformation_exports/tasks/main.yml Co-Authored-By: Jill R <[email protected]> * fix export name * renamed module Co-authored-by: Jill R <[email protected]> * Fix PostgreSQL tests for newer FreeBSD versions (#67658) Use PostgreSQL 9.5 on FreeBSD 12.0, and PostgreSQL 11 on FreeBSD 12.1 and 11.3 due to the Python packages having a dependency on that version of PostgreSQL and automatically uninstalling PostgreSQL 9.5. * Use separate PostgreSQL versions for 12.0 and 12.1 * Update blockinfile.py to change dest: to path: (#67824) * Remove extra Ansible in network automation section header (#67828) * sqs_queue - Move to boto3 and add support for various extra features (#66795) * reworked sqs_queue * Switch default purge_tags behaviour to false. This matches the behaviour of ec2_tag and ecs_tag. * Minor lint / review fixups * Add missing AWS IAM policy for SQS tests * Move integration tests to using module_defaults: group/aws:... * add changelog * Break out the 'compatability' map from our spec definition (gets flagged by the schema validation) * Tweaks based on review * add basic examples * Lint fixups * Switch out NonExistentQueue logic so it's easier to follow * Reorder name argument options for consistency Co-authored-by: Dennis Podkovyrin <[email protected]> * Third batch of incidental integration tests. (#67830) * Copy in incidental windows tests. * Update incidental test aliases. * Add support plugins. * Update target references. * Update sanity ignores. * Update integration-aliases test. * Add to CI. * Fix flake8 errors for checkpoint modules (#67827) We caught these in our checkpoint.checkpoint collection testing. Signed-off-by: Paul Belanger <[email protected]> * Add lookup_dict integration test. (#67836) * Add lookup_dict integration test. * Skip test on python 2.6. * mongodb: Fix documentation (#67806) * Added correct datatypes of parameter * Fixed doc formatting Signed-off-by: Abhijeet Kasurde <[email protected]> * mongodb_user: fix doc formatting (#67763) Signed-off-by: Abhijeet Kasurde <[email protected]> * Test system users and groups. * Add x509_crl_info module (#67539) * Add x509_crl_info module. * Apply suggestions from code review Co-Authored-By: Andrew Klychkov <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> * Resource module for IOS ACL_Interfaces (#66746) * acl_interfaces * Resource module for IOS static routes (#64632) * ios_static_routes * git - use remote_tmp directory (#66762) * fix:git module ignores remote_tmp * WIP: added the changelog fragment and edit comment * Revert "WIP: added the changelog fragment and edit comment" This reverts commit 2f739df619baf65286ee6c79e19bb76286970510. * WIP: added changelog fragments * WIP: added changelog fragment * WIP: fixed spelling in changelog fragment * hostname Add cloudlinuxserver value to hostname.py (#66911) * "Fix" test_get_bin_path by changing mock order (#67730) pytest-mock 2.0.0, when run locally, gets grumpy when os.path.exists is messed with and then another method is patched afterwards. Likely something in the pytest-mock chain uses os.path.exists internally, and since pytest-mock prohibits context-specific patching, there's not a good solution. For now, just patch os.path.exists last. Signed-off-by: Rick Elrod <[email protected]> * line indentation issue in postgresql_set (#67859) Fixed indentation issue with the `register` for the example task in postgresql_set module. * Update vmware_guest_info.py (#67853) forgotten doc replacement of vmware_guest_facts to vmware_guest_info * Add 'OperationAborted' to the list of S3 error codes where we'll retry (#67811) * Resource module for IOS ACL (#66629) * fix ios_acl * Add integration test for regex_search filter. * Fixed incorrect request body when creating VM snapshot with disks (#67815) * Fixed incorrect request body when creating VM snapshot with disks * fixed changlog file extension * fix docker_login doc example (#67852) * Run Powershell modules on windows container via docker connection (#67832) * Run modules on windows container This provides an ability to run Powershell modules on windows container via docker connection. Otherwise, Ansible tries to run python modules on windows containers and fails. * Removing whitespace in the blank lines * Adding a changelog fragment * Switch to using FreeBSD 12.1 (#67659) * implement support for hidden/protected variables gitlab_project_variable (#67461) * #66135 implement support for hidden/protected variables * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Abhijeet Kasurde <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Abhijeet Kasurde <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Abhijeet Kasurde <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Abhijeet Kasurde <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Abhijeet Kasurde <[email protected]> * update example value * fix pep * fix pep8 * fix tailing whitespace * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <[email protected]> * Update test/integration/targets/gitlab_project_variable/tasks/main.yml Co-Authored-By: Felix Fontein <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <[email protected]> * fix recommendations and request changes * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <[email protected]> * Update test/integration/targets/gitlab_project_variable/tasks/main.yml Co-Authored-By: Felix Fontein <[email protected]> * fix undefine module * add missing import * expand documentation * add idempotent check * add changelog * Update changelogs/fragments/67461-gitlab-project-variable-masked-protected.yml Co-Authored-By: Felix Fontein <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <[email protected]> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <[email protected]> * check also for integer_types * expand integration test and check also for float type * append documentation * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <[email protected]> Co-authored-by: Abhijeet Kasurde <[email protected]> Co-authored-by: Felix Fontein <[email protected]> * win_unzip - normalize and compare paths to prevent path traversal (#67799) * Actually inspect the paths and prevent escape * Add integration tests * Generate zip files for use in integration test * Adjust error message * ansible-galaxy - optimise some paths and use fake galaxy int tests (#67685) * ansible-galaxy - optimise some paths and use fake galaxy int tests * Added init, built, and publish tests * Test against both mocked Galaxy and AH server * Finish off writing the install tests * Fix up broken tests * Rename test target and add migrated tests * Use cloud provider for Galaxy implementation * Added blank static config * Use correct alias group * Set release version and fix copy typo * Remove reset step as it is no longer needed * Use sane env var names for test container name * cloudwatchlogs_log_group.py: retention handling improvement (#48004) * cloudwatchlogs_log_group.py: retention handling improvement * add purge_retention_policy to cloudwatchlogs_log_group.py * update version added for purge_retention_policy feature * make retention and purge_retention_policy mutually exclusive * make purge_retention_policy and overwrite mutually exclusive * changelog Co-authored-by: Sloane Hertel <[email protected]> Co-authored-by: Mark Chappell <[email protected]> * Remove unused json import (#67876) Signed-off-by: Paul Belanger <[email protected]> * Clean up unit tests to assist with migration. (#67875) * Split out cache plugin unit tests. * Rename unit tests to match code under test. * Relocate unit test code to match code under test. * Another rename. * Update sanity ignores. * Fourth batch of incidental integration tests. (#67873) * Copy in incidental posix tests. * Update incidental test aliases. * Update target names. * Add support plugins. * Fix paths. * Update ignores. * Update integration-aliases sanity test. * Add incidental tests to CI. * Temporarily remove AIX from CI. * acme_* modules: adjust documentation to reference RFCs 8737 and 8738 instead of the drafts (#67881) * Adjust documentation to reference RFCs 8737 and 8738 instead of the drafts. * More references. * add new module mongodb_info (#67846) * add new module mongodb_info * fix doc and examples * add GPL info * use LooseVersion in the function doc string * Update BOTMETA.yml migrated_to for Netbox components (#67586) * Update BOTMETA.yml to show they have been migrated to netbox_community.ansible_modules * Update BOTMETA.yml to proper format * Expanded from dir to each module migrated_to * Fixed test issues * Updated to new FQCN * Fix vcenter requirements. * ldap_attr: fix small bug (using wrong variable) (#67887) Changed self.name to name in ldap_attr module * NXOS: Manually Configurable Route-Target (#52650) * Renamed auto evpn test * Made sure that the current module is idempotent with additional tests * Added tests for route-target import function * Added tests for route-target export function * Added tests for route-target both function * PEP8 syntax fix * Added route-target import & export function * Added required 'version_added: "2.8"' in the documentation * Updated documentation of new route-target options * Added a test to make sure that in case of `state=absent` on the vrf level the route-target options are ignored. * Specified that the route-target options are ignored in case of `state=absent'. * Updated the doc to the correct format (using 'C()') * Changed the VRF Route Target Syntax Instead of using three different params (route_target_import, route_target_export, route_target_both) the module uses now only one param (route_targets) and the direction is specified for each of the route targets. Example: route_targets: [{rt: '...', direction: '{import|export|both}', state: '...'}] * Updated Description and Examples to reflect new params * Updated "version_added" * pep8 fixes * If rt['direction'] is not definied, we assume default 'both' and run the same routine * Added test with default direction for route-targets * Documentation fixes * VyOS: firewall_interfaces module added (#67254) * firewall_interfaces module added Signed-off-by: rohitthakur2590 <[email protected]> * sanity fixes Signed-off-by: rohitthakur2590 <[email protected]> * sanity fixes Signed-off-by: rohitthakur2590 <[email protected]> * delete opr updated Signed-off-by: rohitthakur2590 <[email protected]> * tests updated Signed-off-by: rohitthakur2590 <[email protected]> * comments incorporated Signed-off-by: rohitthakur2590 <[email protected]> * ci failure fix Signed-off-by: rohitthakur2590 <[email protected]> * Misc documentation fixes (#67863) Signed-off-by: Abhijeet Kasurde <[email protected]> * The different MongoDB test setups collide. (#67895) ci_complete * nxos_lldp_interfaces resource module (#67802) * Added nxos_lldp_interfaces module * Linting * Added RTT, resolved shippable errors * Added new states * New states edit * Updated states * Updated tests * Show all interfaces in facts * Test changes * Added unit tests * Linting * Handled portchannel failing condition * Remove invalid skip aliases in tests. * Skip mongodb tests on all centos versions. The tests were already skipped for versions 6 and 7, and are not passing on version 8. * Fix ansible-test module_utils analysis. * Remove redundant check for pyopenssl (#67901) * Fix AttributeError in ce_lacp on Python 3.9. * Increase unit test coverage timeout. * Fix ansible-test import sanity test venv setup. * Fix ACI unit test on Python 3.8+ * Fix ansible-test constraints for AWS. * win_timezone - Allow for _dstoff timezones (#67892) * win_timezone - Allow for _dstoff timezones * Update win_timezone-Allow-dstoff.yml * Added doc entry for new format Co-authored-by: Jordan Borean <[email protected]> * Skip ios_acls unit test on Python 3.5. * Add Python 3.9 to ansible-test. ci_complete ci_coverage * Increase unit test timeout. * NX-OS ACL interfaces module (#67505) * Rebase * Completed integration tests * Added unit tests * Added warning detection * Updated tests * Completed tests * Linting Linting II YAML Lint Linting * Updated review changes * Updated examples, fixed reviews * Added failure condition * Resolved merge conflict * Split C# module utils to their own test target (#67910) * Split C# module utils to their own test target * Fix up outstanding sanity ignores * Separated ps module_util test targets, added WebRequest tests (#67914) * Separated ps module_util test targets, added WebRequest tests * Simplify header test * Split unit tests into 3 groups. (#67917) * Skip lookup tests on Python 2.6. Lookups are only executed on the controller and Python 2.6 is no longer supported on the controller. * Update default test container to version 1.12. * fix nxos_l2 resource tests (#67916) * ovirt_vm: remove deprecated warning (#67922) * ovirt_vm: remove deprecated warning of boot params * update docs * ovirt: update botmeta deprecated (#67826) * ovirt: update botmeta deprecated * correct deprecate option * remove duplication * add removed_module * add removed_module to external_provider * add imports and metaclass * update misc ovirt * update sanity tests to have correct misc ovirt name Signed-off-by: mnecas <[email protected]> * remove unnecessary sanity ignore * NX-OS ACLs module (#67558) * Added nxos_acls module * Adding tests * Added integration tests * Integration tests update * Updated documentation * Replaced state changes * Added warning detection * Added port-protocol mapping * Added change * Merge update changes * Completed integration tests, rtt * Added unit tests * Linting Added metaclass info * Changed port protocol to str * Fixed shippable errors, added examples * Fixed type error, updated examples * Update nxos_l2_interfaces merged test (#67918) Signed-off-by: NilashishC <[email protected]> * Disable automerge * Unit test cleanup to assist with migration. (#67920) * Move linode unit tests to match module layout. * Fix location of netapp module_utils unit tests. * Update sanity ignores. * Set fallaxy tests as a smoketest * Revert "Temporarily remove AIX from CI." This reverts commit ce0fc4005c7f95d78a719c35faa3975b66ff5272. * O365 connector_card import from dict_transformations Update office_365_connector_card.py to import snake_dict_to_camel_dict from common.dict_transformations instead of ec2, to eliminate collection dependency on AWS collection. * Fix powershell coverage path rewriting. This applies the same rewrite logic to PowerShell coverage as is used for Python coverage. * Automatically enable test plugins after migration. * Update test matrix to prepare for migration. (#67983) * Split fallaxy tests into their own group. This keeps expected pass/fail tests separate during migration prep. * Move network tests down in matrix. This will help keep pass/fail tests grouped together during migration prep. * Group all incidental tests together. This will keep pass/fail tests separate leading up to migration. * Create a dedicated windows-minimal test target. (#67987) * Create a dedicated windows-minimal test target. The windows-minimal target is a copy of the win_ping test, taking the place of that test as the windows minimal test run on multiple python versions. It includes a private copy of the win_ping module so it will work after migration. This will keep tests passing during the migration prep process. * Update sanity ignores. * Skip removed windows CI groups after migration. * Include more test support plugins. (#68015) * Include more test support plugins. Also add missing module_utils `__init__.py` files. * Update sanity ignores. * Remove file exists check from botmeta sanity test. Many of the paths in botmeta will no longer exist after migration, making this check pointless. * Update no-unwanted-files sanity test. This prepares for an additional path to be present after migration. * Split test_play_context_make_become_cmd into files (#68026) * Split test_play_context_make_become_cmd into files For NWO migration. Split the become module assertions into distinct test files and functions. For now, this is done naively - there is probably room to abstract these tests out and remove some of the duplication later on. Signed-off-by: Rick Elrod <[email protected]> * use default_exe variable instead of hardcoding /bin/bash Signed-off-by: Rick Elrod <[email protected]> * Move become plugin tests to their proper directory and rename them accordingly Signed-off-by: Rick Elrod <[email protected]> * Fix up fixtures and imports. * Remove stray file. Co-authored-by: Matt Clay <[email protected]> * Add missing test support plugin. * win - Allow FQCN for win_command and win_shell * Split test_connection into individual files Signed-off-by: Rick Elrod <[email protected]> * Relocate netbox module_utils unit tests. (#68056) * Relocate netbox module_utils unit tests. This puts them where migration expects them. * Update sanity ignores. * make test_raw use setUp instead of global definitions Signed-off-by: Rick Elrod <[email protected]> * Remove assemble from incidental tests. The module and action plugin are now remaining in base. * Intersphinx (#68090) * try to route 2.9 porting guide links to 2.9 module docs * refreshed existing .inv files * better URL * new .inv file for version-specific links * adds targets for version-specific docs * fixes 2.5 porting guide refs * fixes 2.8 porting guide refs * fixes 2.7 porting guide refs * fixes links on ACI guide * adds .inv files for versions 2.5 through 2.8 Co-authored-by: Alicia Cozine <[email protected]> Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Martin Nečas <[email protected]> Co-authored-by: Abhijeet Kasurde <[email protected]> Co-authored-by: Sloane Hertel <[email protected]> Co-authored-by: Alicia Cozine <[email protected]> Co-authored-by: Matt Clay <[email protected]> Co-authored-by: Jordan Borean <[email protected]> Co-authored-by: Geoffrey Purdy <[email protected]> Co-authored-by: Matt Clay <[email protected]> Co-authored-by: Sam Doran <[email protected]> Co-authored-by: Bill Dodd <[email protected]> Co-authored-by: Jan Meerkamp <[email protected]> Co-authored-by: Baptiste Mille-Mathias <[email protected]> Co-authored-by: Bruno Meneguello <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> Co-authored-by: Jannik Vieten <[email protected]> Co-authored-by: Rohit <[email protected]> Co-authored-by: Mark Chappell <[email protected]> Co-authored-by: iridian <[email protected]> Co-authored-by: Connor Adams <[email protected]> Co-authored-by: Stefan Horning <[email protected]> Co-authored-by: Nijin Ashok <[email protected]> Co-authored-by: Robert Gabriel <[email protected]> Co-authored-by: Alex Stephen <[email protected]> Co-authored-by: Paul Belanger <[email protected]> Co-authored-by: Nilashish Chakraborty <[email protected]> Co-authored-by: Mikhail Yohman <[email protected]> Co-authored-by: Markus Fischbacher <[email protected]> Co-authored-by: Stéphane Travassac <[email protected]> Co-authored-by: Arvind Shyamsundar <[email protected]> Co-authored-by: Robert Rotaru <[email protected]> Co-authored-by: John R Barker <[email protected]> Co-authored-by: Christophe Drevet-Droguet <[email protected]> Co-authored-by: Akira Yokochi <[email protected]> Co-authored-by: dexpl <[email protected]> Co-authored-by: Marco Bellaccini <[email protected]> Co-authored-by: flowerysong <[email protected]> Co-authored-by: Jill R <[email protected]> Co-authored-by: Matt Martz <[email protected]> Co-authored-by: James Milligan <[email protected]> Co-authored-by: Min Pae <[email protected]> Co-authored-by: Alan Rominger <[email protected]> Co-authored-by: Steve Boyd <[email protected]> Co-authored-by: anshulbehl <[email protected]> Co-authored-by: Nabil BENDAFI <[email protected]> Co-authored-by: Xu Yuandong <[email protected]> Co-authored-by: GomathiselviS <[email protected]> Co-authored-by: Alexis Camilleri <[email protected]> Co-authored-by: Yanis Guenane <[email protected]> Co-authored-by: Moritz Grimm <[email protected]> Co-authored-by: Brian Coca <[email protected]> Co-authored-by: Sumit Jaiswal <[email protected]> Co-authored-by: James McClune <[email protected]> Co-authored-by: Rick Elrod <[email protected]> Co-authored-by: Graeme Davidson <[email protected]> Co-authored-by: Fred-sun <[email protected]> Co-authored-by: roxyland <[email protected]> Co-authored-by: as-hbk <[email protected]> Co-authored-by: WilliamVannuffelen <[email protected]> Co-authored-by: Noboru Iwamatsu <[email protected]> Co-authored-by: TAKAHASHI Shuuji <[email protected]> Co-authored-by: Markus Bergholz <[email protected]> Co-authored-by: John Nelson <[email protected]> Co-authored-by: Kevin P. Fleming <[email protected]> Co-authored-by: flowerysong <[email protected]> Co-authored-by: sky-joker <[email protected]> Co-authored-by: Prasad Katti <[email protected]> Co-authored-by: Brian Scholer <[email protected]> Co-authored-by: mmoyle <[email protected]> Co-authored-by: adambriand <[email protected]> Co-authored-by: Dennis Podkovyrin <[email protected]> Co-authored-by: narimantos <[email protected]> Co-authored-by: Dainius Sakalinskas <[email protected]> Co-authored-by: Sayed Anisul Hoque <[email protected]> Co-authored-by: misacek007 <[email protected]> Co-authored-by: nemethloci <[email protected]> Co-authored-by: Guillaume Bour <[email protected]> Co-authored-by: Ruheena Ansari <[email protected]> Co-authored-by: Julien PRIGENT <[email protected]> Co-authored-by: Richard Strnad <[email protected]> Co-authored-by: Adharsh Srivats R <[email protected]> Co-authored-by: gp <[email protected]> Co-authored-by: Shachaf92 <[email protected]> Co-authored-by: Jill Rouleau <[email protected]> Co-authored-by: Alicia Cozine <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.10
This issue/PR affects Ansible v2.10
database
Database category
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
mysql
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
support:community
This issue/PR relates to code supported by the Ansible community.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
mysql_db: add dump_extra_args parameter
Fixes: #66238
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/database/mysql/mysql_db.py