Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix launch_template name argument condition in ec2_instance module #51942

Closed
wants to merge 1 commit into from
Closed

Fix launch_template name argument condition in ec2_instance module #51942

wants to merge 1 commit into from

Conversation

piroux
Copy link
Contributor

@piroux piroux commented Feb 8, 2019

Fixes #51941

SUMMARY

Fix the condition in the ec2_instance module to accept the name parameter for the launch_template argument.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module: ec2_instance

@piroux piroux changed the title Fix launchtemplate name argument condition in ec2 instance Fix launch-template name argument condition in ec2_instance module Feb 8, 2019
@piroux piroux changed the title Fix launch-template name argument condition in ec2_instance module Fix launch_template name argument condition in ec2_instance module Feb 8, 2019
@piroux piroux force-pushed the BUGFIX_fix_launchtemplate_name_argument_condition_in_ec2_instance branch from e5a45f5 to df70c6e Compare February 8, 2019 08:54
@ansibot
Copy link
Contributor

ansibot commented Feb 8, 2019

cc @Shaps @ryansb
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 8, 2019

@piroux, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Feb 8, 2019
@Shaps
Copy link
Contributor

Shaps commented Feb 8, 2019

Hi @piroux
Do you think you can add an integration test for this?
Other than that PR looks good.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 8, 2019
@piroux
Copy link
Contributor Author

piroux commented Feb 8, 2019

Sure! I will look into it next week.

@Shaps
Copy link
Contributor

Shaps commented Feb 8, 2019

Great! If you need any help you can find us on either #ansible-devel or #ansible-aws on freenode IRC ;)

@Shaps Shaps mentioned this pull request Feb 8, 2019
Closed
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 16, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2020

cc @jillr @s-hertel @tremble
click here for bot help

@piroux
Copy link
Contributor Author

piroux commented Feb 11, 2020

I am sorry, I don't have time for this PR ATM and I am not using AWS anymore.
You can reassign someone else for the tests or close the PR, however you see fit.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 30, 2020
@ansibot ansibot added the collection Related to Ansible Collections work label Apr 29, 2020
@ansibot ansibot added collection:community.aws needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@Akasurde
Copy link
Member

superseded by ansible-collections/community.aws#111

@Akasurde Akasurde closed this Jun 19, 2020
@ansible ansible locked and limited conversation to collaborators Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud collection:community.aws collection Related to Ansible Collections work has_issue module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use launch_template name in ec2_instance module
4 participants
@piroux @ansibot @Shaps @Akasurde