Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated params from module argspec nxos modules #34911

Merged
merged 5 commits into from
Jan 16, 2018
Merged

Remove deprecated params from module argspec nxos modules #34911

merged 5 commits into from
Jan 16, 2018

Conversation

trishnaguha
Copy link
Member

Signed-off-by: Trishna Guha [email protected]

SUMMARY

Remove deprecated params from module argspec nxos modules

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

modules/network/nxos/nxos_*

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Jan 16, 2018

cc @GGabriele @jedelman8 @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Jan 16, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Jan 16, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 16, 2018
@ansible ansible deleted a comment from ansibot Jan 16, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 16, 2018
@trishnaguha
Copy link
Member Author

Ignore version_added CI error. Should be gone after merge.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Jan 16, 2018
gundalow
gundalow requested changes Jan 16, 2018
View reviewed changes
lib/ansible/modules/network/nxos/_nxos_ip_interface.py
description:
- Version of IP address. If the IP address is IPV4 version should be v4.
If the IP address is IPV6 version should be v6.
default: v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add choices

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Added @gundalow

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jan 16, 2018
@ansible ansible deleted a comment from ansibot Jan 16, 2018
@ansible ansible deleted a comment from ansibot Jan 16, 2018
@ansible ansible deleted a comment from ansibot Jan 16, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 16, 2018
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 16, 2018
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 16, 2018
@ansible ansible deleted a comment from ansibot Jan 16, 2018
@trishnaguha trishnaguha merged commit a727930 into ansible:devel Jan 16, 2018
@trishnaguha trishnaguha deleted the nxos_arg_fix branch January 16, 2018 12:54
This was referenced Jan 16, 2018
Merged
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trishnaguha @ansibot @gundalow @dagwieers