-
Notifications
You must be signed in to change notification settings - Fork 23.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated params from module argspec nxos modules #34911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.5
This issue/PR affects Ansible v2.5
bugfix_pull_request
core_review
In order to be merged, this PR must follow the core review workflow.
deprecated
This issue/PR relates to a deprecated module.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
networking
Network category
nxos
Cisco NXOS community
support:network
This issue/PR relates to code supported by the Ansible Network Team.
test
This PR relates to tests.
labels
Jan 16, 2018
trishnaguha
removed
the
needs_triage
Needs a first human triage before being processed.
label
Jan 16, 2018
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Jan 16, 2018
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Jan 16, 2018
Ignore |
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI.
labels
Jan 16, 2018
gundalow
requested changes
Jan 16, 2018
description: | ||
- Version of IP address. If the IP address is IPV4 version should be v4. | ||
If the IP address is IPV6 version should be v6. | ||
default: v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add choices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Added @gundalow
trishnaguha
force-pushed
the
nxos_arg_fix
branch
from
January 16, 2018 12:04
074d65d
to
b81166f
Compare
ansibot
removed
the
ci_verified
Changes made in this PR are causing tests to fail.
label
Jan 16, 2018
ansibot
added
the
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
label
Jan 16, 2018
trishnaguha
force-pushed
the
nxos_arg_fix
branch
from
January 16, 2018 12:42
b81166f
to
3a3ce91
Compare
ansibot
removed
the
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
label
Jan 16, 2018
gundalow
approved these changes
Jan 16, 2018
This was referenced Jan 16, 2018
ansibot
added
bug
This issue/PR relates to a bug.
and removed
bugfix_pull_request
labels
Mar 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.5
This issue/PR affects Ansible v2.5
bug
This issue/PR relates to a bug.
cisco
Cisco technologies
deprecated
This issue/PR relates to a deprecated module.
module
This issue/PR relates to a module.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
networking
Network category
nxos
Cisco NXOS community
support:network
This issue/PR relates to code supported by the Ansible Network Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trishna Guha [email protected]
SUMMARY
Remove deprecated params from module argspec nxos modules
ISSUE TYPE
COMPONENT NAME
modules/network/nxos/nxos_*
ANSIBLE VERSION