check if existing network is VDS and has port attribute

[strattner]

SUMMARY

When checking to see if the guest network has changed, attributes of the existing and new network are compared. However, the current check assumes that if the new network is associated with a VDS, the existing network must be as well - the end result that it tries to compare a "port" attribute, which fails when the existing network is not associated with a VDS.

For example, when a VM has existing network 'VM Network' (the default), and an attempt is made to change it to a portgroup that is associated to a VDS, the following error is generated:

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: AttributeError: 'vim.vm.device.VirtualEthernetCard.NetworkBackingIn' object has no attribute 'port'
fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "module_stderr": "Traceback (most recent call last):\n  File \"/tmp/ansible_UkXVTS/ansible_module_vmware_guest.py\", line 1503, in <module>\n    main()\n  File \"/tmp/ansible_UkXVTS/ansible_module_vmware_guest.py\", line 1479, in main\n    result = pyv.reconfigure_vm()\n  File \"/tmp/ansible_UkXVTS/ansible_module_vmware_guest.py\", line 1351, in reconfigure_vm\n    self.configure_network(vm_obj=self.current_vm_obj)\n  File \"/tmp/ansible_UkXVTS/ansible_module_vmware_guest.py\", line 727, in configure_network\n    (nic.device.backing.port.portgroupKey != pg_obj.key or\nAttributeError: '**vim.vm.device.VirtualEthernetCard.NetworkBackingIn' object has no attribute 'port'**\n", "module_stdout": "", "msg": "MODULE FAILURE", "rc": 0}

The change that was made was to check whether the existing network was a VDS first, before attempting to compare VDS-related attributes.

Fixes #30524 that I had opened, and fix was based on recommended change by @nrwahl2

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

cloud/vmware/vmware_guest.py

ANSIBLE VERSION

ansible 2.5.0 (issue30524 9fe65e0420) last updated 2017/10/04 17:44:35 (GMT +000)
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/ansible/lib/ansible
  executable location = /root/ansible/bin/ansible
  python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]

ADDITIONAL INFORMATION

[ansibot]

cc @Akasurde @dagwieers @dav1x @jctanner @nerzhul
click here for bot help

[Akasurde]

@strattner Could you please add integration test for this change ?

[mattclay]

Closing and re-opening to trigger CI.

[ansibot]

cc @pdellaert
click here for bot help

[Akasurde]

@strattner Are you still working on this ?

[strattner]

@Akasurde I am not sure what else needs to be done. I submitted this change, is there something specific I should do?

[Akasurde]

Closing and re-opening for CI.

[l3m]

This solved my problem (#32975), so please:

shipit !