Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facts: fix SPARC cpu count on linux (#30261) #30791

Closed
wants to merge 1 commit into from
Closed

facts: fix SPARC cpu count on linux (#30261) #30791

wants to merge 1 commit into from

Conversation

zorun
Copy link
Contributor

@zorun zorun commented Sep 23, 2017

On sparc64, /proc/cpuinfo has no usual 'model name', 'Processor', 'vendor_id', 'Vendor',
as a result "ansible_processor_vcpus" is always 1.
Add check element "ncpus active" to fix the issue.

(cherry picked from commit e93ecac)

See #30261

@mator
facts: fix SPARC cpu count on linux (ansible#30261)
d8a84ab 
On sparc64, /proc/cpuinfo has no usual 'model name', 'Processor', 'vendor_id', 'Vendor',
as a result "ansible_processor_vcpus" is always 1.
Add check element "ncpus active" to fix the issue.

(cherry picked from commit e93ecac)
@ansibot
Copy link
Contributor

ansibot commented Sep 23, 2017

@zorun Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. module_utils/facts needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 23, 2017
@alikins
Copy link
Contributor

alikins commented Sep 25, 2017

fix for stable-2.4 in 3aa7941 via cherrypick of e93ecac from #30261

@alikins alikins closed this Sep 25, 2017
@alikins alikins added affects_2.4 This issue/PR affects Ansible v2.4 and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_triage Needs a first human triage before being processed. affects_2.5 This issue/PR affects Ansible v2.5 labels Sep 25, 2017
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 backport This PR does not target the devel branch. module_utils/facts needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zorun @ansibot @alikins @mator