Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added shell out errors #26012

Closed
wants to merge 3 commits into from
Closed

Added shell out errors #26012

wants to merge 3 commits into from

Conversation

Shaps
Copy link
Contributor

@Shaps Shaps commented Jun 22, 2017

updated functions to call self.reporter.error, added codes to doc page

SUMMARY

Addresses #18181. Added methods to check for subprocess.Popen and os.call

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

validate-modules

ANSIBLE VERSION

N/A

@ansibot
Copy link
Contributor

ansibot commented Jun 22, 2017

cc @dharmabumstead
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 docs_pull_request needs_triage Needs a first human triage before being processed. labels Jun 22, 2017
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jun 23, 2017
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 28, 2017
@ansibot ansibot added the test This PR relates to tests. label Jul 18, 2017
dharmabumstead
dharmabumstead approved these changes Jul 26, 2017
View reviewed changes
Copy link
Contributor

@dharmabumstead dharmabumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc updates OK. Core team devs, please review.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 2, 2017
@ansibot
Copy link
Contributor

ansibot commented Feb 14, 2018

cc @mattclay
click here for bot help

@mattclay
Copy link
Member

Longer term I'd like to use pylint to check for these kinds of things, but this works OK in the short term.

@gundalow gundalow mentioned this pull request Feb 15, 2018
Closed
@ansibot ansibot added docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. and removed docs_pull_request labels Mar 1, 2018
@dharmabumstead
Copy link
Contributor

Closing this one. Feel free to rebase and reopen.

@Shaps
Copy link
Contributor Author

Shaps commented Apr 6, 2018

If this is still considered of use I'll reopen a new one instead of rebasing this branch which has gone too far behind

@abadger
Copy link
Contributor

abadger commented Jun 11, 2018

@Shaps I talked to @mattclay and he says go ahead and open a new PR. He does want it; just got behind on reviewing it. One note review note he had was that we should use the ignore.txt file instead of hard-coding the whitelist into validate-modules.

@Shaps Shaps mentioned this pull request Jun 14, 2018
Merged
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dharmabumstead dharmabumstead dharmabumstead approved these changes

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Shaps @ansibot @mattclay @dharmabumstead @abadger @s-hertel