-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes.core: Add turbo mode job #1074
Conversation
a4f216d
to
434fb2a
Compare
The test is failing with:
|
@goneri @Akasurde I think what's going on here is:
I'm not sure what the best way to address this is. The only thing I can think of is for that one failing test to just disable turbo mode. |
Agreed, I would also disable turbo mode for the test. I work on a patch for that. |
It seems to be unrelated. I can reproduce the problem without the turbo mode. |
We actually always end up running the |
Thats really strange as it was working before (it has been merged so this mean test validated) |
|
||
- job: | ||
name: ansible-test-molecule-kubernetes-core-with-turbo | ||
parent: ansible-test-molecule-kubernetes-core |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Added an additional molecule job to test ``ENABLE_TURBO_MODE=True`` and cloud.common. Signed-off-by: Abhijeet Kasurde <[email protected]>
@goneri Could you please merge this? Thanks in advance. |
Disable turbo mode for the validate tests Depends-On: ansible/ansible-zuul-jobs#1074 Switching virtualenvs in the test suite does not work so well with turbo mode enabled because the module may not be executed by the virtualenv that is specified for that task. Reviewed-by: None <None> Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: None <None>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added an additional voting molecule job to test
ENABLE_TURBO_MODE=True
and cloud.common.
Signed-off-by: Abhijeet Kasurde [email protected]