Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes.core: Add turbo mode job #1074

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Aug 26, 2021

Added an additional voting molecule job to test ENABLE_TURBO_MODE=True
and cloud.common.

Signed-off-by: Abhijeet Kasurde [email protected]

@Akasurde Akasurde force-pushed the non_voting branch 2 times, most recently from a4f216d to 434fb2a Compare August 26, 2021 13:54
@Akasurde Akasurde changed the title kubernetes.core: Add non voting turbo mode job kubernetes.core: Add turbo mode job Aug 26, 2021
@goneri
Copy link
Collaborator

goneri commented Aug 30, 2021

The test is failing with:

TASK [assert that task failed with proper message] *****************************
fatal: [localhost]: FAILED! => {"msg": "The conditional check '\"kubernetes >= 17.17.0 is required\" in _result.msg' failed. The error was: error while evaluating conditional (\"kubernetes >= 17.17.0 is required\" in _result.msg): 'dict object' has no attribute 'msg'"}

@gravesm
Copy link
Member

gravesm commented Aug 30, 2021

@goneri @Akasurde I think what's going on here is:

  1. Earlier module in test suite spawns turbo daemon using virtualenv with kubernetes >= 17.17.0 installed.
  2. Later module is initially spawned using virtualenv with kubernetes < 17.17.0 installed.
  3. Later module then uses turbo daemon spawned by earlier module to actually execute the module.
  4. Later module fails because it's assuming kubernetes < 17.17.0 is installed, but this is not true by the time module execution happens.

I'm not sure what the best way to address this is. The only thing I can think of is for that one failing test to just disable turbo mode.

@goneri
Copy link
Collaborator

goneri commented Aug 30, 2021

@goneri @Akasurde I think what's going on here is:

  1. Earlier module in test suite spawns turbo daemon using virtualenv with kubernetes >= 17.17.0 installed.
  2. Later module is initially spawned using virtualenv with kubernetes < 17.17.0 installed.
  3. Later module then uses turbo daemon spawned by earlier module to actually execute the module.
  4. Later module fails because it's assuming kubernetes < 17.17.0 is installed, but this is not true by the time module execution happens.

I'm not sure what the best way to address this is. The only thing I can think of is for that one failing test to just disable turbo mode.

Agreed, I would also disable turbo mode for the test. I work on a patch for that.

@goneri
Copy link
Collaborator

goneri commented Aug 30, 2021

@goneri @Akasurde I think what's going on here is:

  1. Earlier module in test suite spawns turbo daemon using virtualenv with kubernetes >= 17.17.0 installed.
  2. Later module is initially spawned using virtualenv with kubernetes < 17.17.0 installed.
  3. Later module then uses turbo daemon spawned by earlier module to actually execute the module.
  4. Later module fails because it's assuming kubernetes < 17.17.0 is installed, but this is not true by the time module execution happens.

I'm not sure what the best way to address this is. The only thing I can think of is for that one failing test to just disable turbo mode.

Agreed, I would also disable turbo mode for the test. I work on a patch for that.

It seems to be unrelated. I can reproduce the problem without the turbo mode.

@goneri
Copy link
Collaborator

goneri commented Aug 30, 2021

@goneri @Akasurde I think what's going on here is:

  1. Earlier module in test suite spawns turbo daemon using virtualenv with kubernetes >= 17.17.0 installed.
  2. Later module is initially spawned using virtualenv with kubernetes < 17.17.0 installed.
  3. Later module then uses turbo daemon spawned by earlier module to actually execute the module.
  4. Later module fails because it's assuming kubernetes < 17.17.0 is installed, but this is not true by the time module execution happens.

I'm not sure what the best way to address this is. The only thing I can think of is for that one failing test to just disable turbo mode.

Agreed, I would also disable turbo mode for the test. I work on a patch for that.

It seems to be unrelated. I can reproduce the problem without the turbo mode.

We actually always end up running the k8s_info action. The test is broken.

@abikouo
Copy link
Collaborator

abikouo commented Aug 31, 2021

@goneri @Akasurde I think what's going on here is:

  1. Earlier module in test suite spawns turbo daemon using virtualenv with kubernetes >= 17.17.0 installed.
  2. Later module is initially spawned using virtualenv with kubernetes < 17.17.0 installed.
  3. Later module then uses turbo daemon spawned by earlier module to actually execute the module.
  4. Later module fails because it's assuming kubernetes < 17.17.0 is installed, but this is not true by the time module execution happens.

I'm not sure what the best way to address this is. The only thing I can think of is for that one failing test to just disable turbo mode.

Agreed, I would also disable turbo mode for the test. I work on a patch for that.

It seems to be unrelated. I can reproduce the problem without the turbo mode.

We actually always end up running the k8s_info action. The test is broken.

Thats really strange as it was working before (it has been merged so this mean test validated)


- job:
name: ansible-test-molecule-kubernetes-core-with-turbo
parent: ansible-test-molecule-kubernetes-core

This comment was marked as resolved.

Added an additional molecule job to test ``ENABLE_TURBO_MODE=True``
and cloud.common.

Signed-off-by: Abhijeet Kasurde <[email protected]>
@Akasurde
Copy link
Member Author

Akasurde commented Sep 1, 2021

@goneri Could you please merge this? Thanks in advance.

ansible-zuul bot pushed a commit to ansible-collections/kubernetes.core that referenced this pull request Sep 1, 2021
Disable turbo mode for the validate tests

Depends-On: ansible/ansible-zuul-jobs#1074
Switching virtualenvs in the test suite does not work so well with turbo
mode enabled because the module may not be executed by the virtualenv
that is specified for that task.

Reviewed-by: None <None>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: None <None>
@goneri goneri added the gate label Sep 1, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 208a850 into ansible:master Sep 1, 2021
@Akasurde Akasurde deleted the non_voting branch September 1, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants