Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass "die-with-parent" option to bwrap. #380

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Pass "die-with-parent" option to bwrap. #380

merged 1 commit into from
Oct 23, 2019

Conversation

wenottingham
Copy link
Contributor

From the man page:
Ensures child process (COMMAND) dies when bwrap's parent dies. Kills (SIGKILL) all
bwrap sandbox processes in sequence from parent to child including COMMAND process
when bwrap or bwrap's parent dies.

We've seen cases where SSH controlmaster processes detach and stay running
leaving a stale bubblewrap process that prevents cleanup. This seems to
catch those cases.

@wenottingham wenottingham mentioned this pull request Oct 23, 2019
Closed
@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Oct 23, 2019

Build failed.

@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Oct 23, 2019

Build failed.

@wenottingham
Pass "die-with-parent" option to bwrap.
a2fadf1 
From the man page:
  Ensures child process (COMMAND) dies when bwrap's parent dies. Kills (SIGKILL) all bwrap sandbox processes in sequence from
  parent to child including COMMAND process when bwrap or bwrap's parent dies.

We've seen cases where SSH controlmaster processes detach and stay running
leaving a stale bubblewrap process that prevents cleanup. This seems to
catch those cases.
@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Oct 23, 2019

Build succeeded.

@wenottingham wenottingham requested a review from matburt October 23, 2019 19:20
@angystardust angystardust mentioned this pull request Oct 23, 2019
Closed
@matburt
Copy link
Member

matburt commented Oct 23, 2019

This is interesting, now I definitely recall seeing this in part of our initial analysis.

@matburt matburt added the gate label Oct 23, 2019
@angystardust
Copy link

I can confirm that this little magic trick fixes my template jobs on awx 8.0! Thanks

@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Oct 23, 2019

Build succeeded (gate pipeline).

@ansible-zuul ansible-zuul bot merged commit 78b776f into ansible:master Oct 23, 2019
@aquilinux
Copy link

i can confirm that --die-with-parent fixes MrMEEE/awx-build#163 for me as well.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matburt matburt matburt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenottingham @matburt @angystardust @aquilinux