Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin minor version of aiohttp #723

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Alex-Izquierdo
Copy link
Contributor

Yesterday, 3.11 version of aiohttp was released with breaking changes which breaks aioresponses library used for our mocks and as consequence some of our tests are failing.
Ref: pnuckowski/aioresponses#262

Regardless of whether this is fixed in aioresponses, aiohttp can introduce breaking changes in minor versions, so I pin it to the latest tested version as this library is critical for the stability in some of our features.

@Alex-Izquierdo Alex-Izquierdo requested a review from a team November 14, 2024 10:43
Copy link

sonarcloud bot commented Nov 14, 2024

@bdraco
Copy link

bdraco commented Nov 14, 2024

We are going to ship a 3.11.1 to restore back-compat for pnuckowski/aioresponses#262

I want to note that aioresponses could break at any patch release of aiohttp since third party libs that monkey patch aiohttp internals are not something we generally plan for upstream.

If you can use aiohttp's pytest plugin you should be a lot safer off from breaking changes in test infrastructure.

@Alex-Izquierdo
Copy link
Contributor Author

We are going to ship a 3.11.1 to restore back-compat for pnuckowski/aioresponses#262

I want to note that aioresponses could break at any patch release of aiohttp since third party libs that monkey patch aiohttp internals are not something we generally plan for upstream.

If you can use aiohttp's pytest plugin you should be a lot safer off from breaking changes in test infrastructure.

Thanks for your feedback @bdraco
We will explore the plugin that you suggest.

@Alex-Izquierdo Alex-Izquierdo merged commit 1c0b1c8 into ansible:main Nov 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants