Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert notify related checks, errors, transforms for listen and tests #4205

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Revert notify related checks, errors, transforms for listen and tests #4205

merged 2 commits into from
Jun 4, 2024

Conversation

audgirka
Copy link
Contributor

@audgirka audgirka commented Jun 4, 2024 •
edited by ssbarnea
Loading

This PR

It will still transform handler name and task's notify if a match is found

Fixes: #4168

@github-actions github-actions bot added the bug label Jun 4, 2024
@cidrblock cidrblock self-requested a review June 4, 2024 12:35
@audgirka audgirka marked this pull request as ready for review June 4, 2024 12:37
@audgirka audgirka requested a review from a team as a code owner June 4, 2024 12:37
@audgirka audgirka requested review from ssbarnea and priyamsahoo and removed request for a team June 4, 2024 12:37
@cidrblock cidrblock mentioned this pull request Jun 4, 2024
Closed
@audgirka audgirka marked this pull request as draft June 4, 2024 12:40
@ssbarnea ssbarnea marked this pull request as ready for review June 4, 2024 14:58
@ssbarnea ssbarnea merged commit 3f6f87f into ansible:main Jun 4, 2024
13 of 22 checks passed
gardar added a commit to gardar/ansible-collection-prometheus that referenced this pull request Jun 11, 2024
@gardar
fix: ansible-lint no longer incorrectly flags handlers with name[casing]
34044ca 
ansible/ansible-lint#4205
Signed-off-by: gardar <[email protected]>
gardar added a commit to gardar/ansible-collection-prometheus that referenced this pull request Oct 18, 2024
@gardar
fix: ansible-lint no longer incorrectly flags handlers with name[casing]
e983d01 
ansible/ansible-lint#4205
Signed-off-by: gardar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

name[casing] incorrectly catches notify triggering listen
3 participants
@audgirka @cidrblock @ssbarnea